Skip to content

Commit a57ff76

Browse files
authored
[PR #11114/758738e backport][3.12] Downgrade connector close error to debug (#11115)
1 parent 06887a9 commit a57ff76

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

CHANGES/11114.misc.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Downgraded the logging level for connector close errors from ERROR to DEBUG, as these are expected behavior with TLS 1.3 connections -- by :user:`bdraco`.

aiohttp/connector.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import asyncio
22
import functools
3-
import logging
43
import random
54
import socket
65
import sys
@@ -60,6 +59,7 @@
6059
set_exception,
6160
set_result,
6261
)
62+
from .log import client_logger
6363
from .resolver import DefaultResolver
6464

6565
if sys.version_info >= (3, 12):
@@ -137,7 +137,7 @@ async def _wait_for_close(waiters: List[Awaitable[object]]) -> None:
137137
results = await asyncio.gather(*waiters, return_exceptions=True)
138138
for res in results:
139139
if isinstance(res, Exception):
140-
logging.error("Error while closing connector: %r", res)
140+
client_logger.debug("Error while closing connector: %r", res)
141141

142142

143143
class Connection:

tests/test_connector.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import asyncio
33
import gc
44
import hashlib
5+
import logging
56
import platform
67
import socket
78
import ssl
@@ -309,6 +310,7 @@ async def test_close_with_exception_during_closing(
309310
loop: asyncio.AbstractEventLoop, caplog: pytest.LogCaptureFixture
310311
) -> None:
311312
"""Test that exceptions during connection closing are logged."""
313+
caplog.set_level(logging.DEBUG)
312314
proto = create_mocked_conn()
313315

314316
# Make the closed future raise an exception when awaited
@@ -327,7 +329,7 @@ async def test_close_with_exception_during_closing(
327329

328330
# Check that the error was logged
329331
assert len(caplog.records) == 1
330-
assert caplog.records[0].levelname == "ERROR"
332+
assert caplog.records[0].levelname == "DEBUG"
331333
assert "Error while closing connector" in caplog.records[0].message
332334
assert "RuntimeError('Connection close failed')" in caplog.records[0].message
333335

0 commit comments

Comments
 (0)