Skip to content

Commit b1da65e

Browse files
authored
Remove ABC names for isinstance checks (#11088)
1 parent 51698fb commit b1da65e

File tree

5 files changed

+10
-12
lines changed

5 files changed

+10
-12
lines changed

CHANGES/11088.misc.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
11085.misc.rst

aiohttp/client_reqrep.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import sys
88
import traceback
99
import warnings
10-
from collections.abc import Mapping as ABCMapping
10+
from collections.abc import Mapping
1111
from hashlib import md5, sha1, sha256
1212
from http.cookies import CookieError, Morsel, SimpleCookie
1313
from types import MappingProxyType, TracebackType
@@ -1006,7 +1006,7 @@ def update_cookies(self, cookies: Optional[LooseCookies]) -> None:
10061006
c.load(self.headers.get(hdrs.COOKIE, ""))
10071007
del self.headers[hdrs.COOKIE]
10081008

1009-
if isinstance(cookies, ABCMapping):
1009+
if isinstance(cookies, Mapping):
10101010
iter_cookies = cookies.items()
10111011
else:
10121012
iter_cookies = cookies # type: ignore[assignment]

aiohttp/cookiejar.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import time
1111
import warnings
1212
from collections import defaultdict
13-
from collections.abc import Mapping as ABCMapping
13+
from collections.abc import Mapping
1414
from http.cookies import BaseCookie, Morsel, SimpleCookie
1515
from typing import (
1616
DefaultDict,
@@ -237,7 +237,7 @@ def update_cookies(self, cookies: LooseCookies, response_url: URL = URL()) -> No
237237
# Don't accept cookies from IPs
238238
return
239239

240-
if isinstance(cookies, ABCMapping):
240+
if isinstance(cookies, Mapping):
241241
cookies = cookies.items()
242242

243243
for name, cookie in cookies:

aiohttp/multipart.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import uuid
77
import warnings
88
from collections import deque
9-
from collections.abc import Mapping as ABCMapping, Sequence as ABCSequence
9+
from collections.abc import Mapping, Sequence
1010
from types import TracebackType
1111
from typing import (
1212
TYPE_CHECKING,
@@ -15,9 +15,7 @@
1515
Dict,
1616
Iterator,
1717
List,
18-
Mapping,
1918
Optional,
20-
Sequence,
2119
Tuple,
2220
Type,
2321
Union,
@@ -958,12 +956,12 @@ def append_form(
958956
headers: Optional[Mapping[str, str]] = None,
959957
) -> Payload:
960958
"""Helper to append form urlencoded part."""
961-
assert isinstance(obj, (ABCSequence, ABCMapping))
959+
assert isinstance(obj, (Sequence, Mapping))
962960

963961
if headers is None:
964962
headers = CIMultiDict()
965963

966-
if isinstance(obj, ABCMapping):
964+
if isinstance(obj, Mapping):
967965
obj = list(obj.items())
968966
data = urlencode(obj, doseq=True)
969967

aiohttp/payload.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,14 @@
77
import sys
88
import warnings
99
from abc import ABC, abstractmethod
10-
from collections.abc import Iterable as ABCIterable
10+
from collections.abc import Iterable
1111
from itertools import chain
1212
from typing import (
1313
IO,
1414
TYPE_CHECKING,
1515
Any,
1616
Dict,
1717
Final,
18-
Iterable,
1918
List,
2019
Optional,
2120
Set,
@@ -138,7 +137,7 @@ def register(
138137
self._first.append((factory, type))
139138
elif order is Order.normal:
140139
self._normal.append((factory, type))
141-
if isinstance(type, ABCIterable):
140+
if isinstance(type, Iterable):
142141
for t in type:
143142
self._normal_lookup[t] = factory
144143
else:

0 commit comments

Comments
 (0)