Remove old backwards-compatibility stub (#8596)

Author: Dreamsorcerer

CHANGES/8596.breaking.rst

@@ -0,0 +1 @@
+Removed old async compatibility from ``ClientResponse.release()`` -- by :user:`Dreamsorcerer`.

aiohttp/client_reqrep.py

@@ -50,7 +50,6 @@
     basicauth_from_netrc,
     is_expected_content_type,
     netrc_from_env,
-    noop,
     parse_mimetype,
     reify,
     set_exception,
@@ -993,15 +992,14 @@ def close(self) -> None:
             self._connection.close()
             self._connection = None
 
-    def release(self) -> Any:
+    def release(self) -> None:
         if not self._released:
             self._notify_content()
 
         self._closed = True
 
         self._cleanup_writer()
         self._release_connection()
-        return noop()
 
     @property
     def ok(self) -> bool:

aiohttp/helpers.py

@@ -30,7 +30,6 @@
     Callable,
     ContextManager,
     Dict,
-    Generator,
     Generic,
     Iterable,
     Iterator,
@@ -109,11 +108,6 @@
 TOKEN = CHAR ^ CTL ^ SEPARATORS
 
 
-class noop:
-    def __await__(self) -> Generator[None, None, None]:
-        yield
-
-
 json_re = re.compile(r"(?:application/|[\w.-]+/[\w.+-]+?\+)json$", re.IGNORECASE)
 
 

aiohttp/multipart.py

@@ -247,7 +247,7 @@ async def release(self) -> None:
 
         All remaining content is read to the void.
         """
-        await self.resp.release()
+        self.resp.release()
 
 
 class BodyPartReader:

tests/test_client_session.py

@@ -546,7 +546,7 @@ async def handler(request):
 
     jar.update_cookies.reset_mock()
     resp = await session.get("/")
-    await resp.release()
+    resp.release()
 
     # Filtering the cookie jar before sending the request,
     # getting the request URL as only parameter

tests/test_multipart.py

@@ -107,13 +107,11 @@ async def test_next(self) -> None:
 
     async def test_release(self) -> None:
         wrapper = MultipartResponseWrapper(mock.Mock(), mock.Mock())
-        wrapper.resp.release = make_mocked_coro(None)
         await wrapper.release()
         assert wrapper.resp.release.called
 
     async def test_release_when_stream_at_eof(self) -> None:
         wrapper = MultipartResponseWrapper(mock.Mock(), mock.Mock())
-        wrapper.resp.release = make_mocked_coro(None)
         wrapper.stream.next = make_mocked_coro(b"")
         wrapper.stream.at_eof.return_value = True
         await wrapper.next()