Skip to content

Commit c7e03ef

Browse files
[PR #11088/b1da65e1 backport][3.12] Remove ABC names for isinstance checks (#11089)
1 parent 73cca7c commit c7e03ef

File tree

5 files changed

+10
-12
lines changed

5 files changed

+10
-12
lines changed

CHANGES/11088.misc.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
11085.misc.rst

aiohttp/client_reqrep.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import sys
88
import traceback
99
import warnings
10-
from collections.abc import Mapping as ABCMapping
10+
from collections.abc import Mapping
1111
from hashlib import md5, sha1, sha256
1212
from http.cookies import CookieError, Morsel, SimpleCookie
1313
from types import MappingProxyType, TracebackType
@@ -1085,7 +1085,7 @@ def update_cookies(self, cookies: Optional[LooseCookies]) -> None:
10851085
c.load(self.headers.get(hdrs.COOKIE, ""))
10861086
del self.headers[hdrs.COOKIE]
10871087

1088-
if isinstance(cookies, ABCMapping):
1088+
if isinstance(cookies, Mapping):
10891089
iter_cookies = cookies.items()
10901090
else:
10911091
iter_cookies = cookies # type: ignore[assignment]

aiohttp/cookiejar.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import time
1212
import warnings
1313
from collections import defaultdict
14-
from collections.abc import Mapping as ABCMapping
14+
from collections.abc import Mapping
1515
from http.cookies import BaseCookie, Morsel, SimpleCookie
1616
from typing import (
1717
DefaultDict,
@@ -236,7 +236,7 @@ def update_cookies(self, cookies: LooseCookies, response_url: URL = URL()) -> No
236236
# Don't accept cookies from IPs
237237
return
238238

239-
if isinstance(cookies, ABCMapping):
239+
if isinstance(cookies, Mapping):
240240
cookies = cookies.items()
241241

242242
for name, cookie in cookies:

aiohttp/multipart.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import uuid
77
import warnings
88
from collections import deque
9-
from collections.abc import Mapping as ABCMapping, Sequence as ABCSequence
9+
from collections.abc import Mapping, Sequence
1010
from types import TracebackType
1111
from typing import (
1212
TYPE_CHECKING,
@@ -15,9 +15,7 @@
1515
Dict,
1616
Iterator,
1717
List,
18-
Mapping,
1918
Optional,
20-
Sequence,
2119
Tuple,
2220
Type,
2321
Union,
@@ -954,12 +952,12 @@ def append_form(
954952
headers: Optional[Mapping[str, str]] = None,
955953
) -> Payload:
956954
"""Helper to append form urlencoded part."""
957-
assert isinstance(obj, (ABCSequence, ABCMapping))
955+
assert isinstance(obj, (Sequence, Mapping))
958956

959957
if headers is None:
960958
headers = CIMultiDict()
961959

962-
if isinstance(obj, ABCMapping):
960+
if isinstance(obj, Mapping):
963961
obj = list(obj.items())
964962
data = urlencode(obj, doseq=True)
965963

aiohttp/payload.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,14 @@
77
import sys
88
import warnings
99
from abc import ABC, abstractmethod
10-
from collections.abc import Iterable as ABCIterable
10+
from collections.abc import Iterable
1111
from itertools import chain
1212
from typing import (
1313
IO,
1414
TYPE_CHECKING,
1515
Any,
1616
Dict,
1717
Final,
18-
Iterable,
1918
List,
2019
Optional,
2120
Set,
@@ -138,7 +137,7 @@ def register(
138137
self._first.append((factory, type))
139138
elif order is Order.normal:
140139
self._normal.append((factory, type))
141-
if isinstance(type, ABCIterable):
140+
if isinstance(type, Iterable):
142141
for t in type:
143142
self._normal_lookup[t] = factory
144143
else:

0 commit comments

Comments
 (0)