Skip to content

Commit cbd64a6

Browse files
committed
Drop redundant test
1 parent d5e4d6a commit cbd64a6

File tree

1 file changed

+1
-18
lines changed

1 file changed

+1
-18
lines changed

tests/test_connector.py

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -184,23 +184,6 @@ def test_release_close(self):
184184
self.assertFalse(conn._conns)
185185
self.assertTrue(tr.close.called)
186186

187-
def test_release_dont_clean_conns(self):
188-
# see issue #253
189-
conn = aiohttp.BaseConnector(loop=self.loop)
190-
req = unittest.mock.Mock()
191-
resp = unittest.mock.Mock()
192-
resp.message.should_close = True
193-
req.response = resp
194-
195-
key = ('127.0.0.1', 80, False)
196-
197-
tr, proto = unittest.mock.Mock(), unittest.mock.Mock()
198-
conn._conns[key] = [(tr, proto, 123)]
199-
200-
conn._release(key, req, tr, proto)
201-
self.assertEqual({key: [(tr, proto, 123)]}, conn._conns)
202-
self.assertTrue(tr.close.called)
203-
204187
def test_release_pop_empty_conns(self):
205188
# see issue #253
206189
conn = aiohttp.BaseConnector(loop=self.loop)
@@ -219,7 +202,7 @@ def test_release_pop_empty_conns(self):
219202
self.assertTrue(tr.close.called)
220203

221204
def test_release_close_do_not_delete_existing_connections(self):
222-
key = 1
205+
key = ('127.0.0.1', 80, False)
223206
tr1, proto1 = unittest.mock.Mock(), unittest.mock.Mock()
224207

225208
conn = aiohttp.BaseConnector(share_cookies=True, loop=self.loop)

0 commit comments

Comments
 (0)