[PR #3753/401c256 backport][3.11] Enforce URL for cookie_jar.filter_cookies() call (#9715)

Co-authored-by: Andrew Svetlov <[email protected]>

Author: bdraco

aiohttp/cookiejar.py

@@ -9,6 +9,7 @@
 import pickle
 import re
 import time
+import warnings
 from collections import defaultdict
 from http.cookies import BaseCookie, Morsel, SimpleCookie
 from typing import (
@@ -309,7 +310,14 @@ def filter_cookies(self, request_url: URL = URL()) -> "BaseCookie[str]":
         if not self._cookies:
             # Skip rest of function if no non-expired cookies.
             return filtered
-        request_url = URL(request_url)
+        if type(request_url) is not URL:
+            warnings.warn(
+                "filter_cookies expects yarl.URL instances only,"
+                f"and will stop working in 4.x, got {type(request_url)}",
+                DeprecationWarning,
+                stacklevel=2,
+            )
+            request_url = URL(request_url)
         hostname = request_url.raw_host or ""
 
         is_not_secure = request_url.scheme not in ("https", "wss")

tests/test_cookiejar.py

@@ -313,6 +313,13 @@ async def test_filter_cookies_with_domain_path_lookup_multilevelpath(
         assert c in expected_cookies
 
 
+async def test_filter_cookies_str_deprecated(loop: asyncio.AbstractEventLoop) -> None:
+    jar = CookieJar()
+    jar.update_cookies(SimpleCookie("shared-cookie=first; Domain=example.com;"))
+    with pytest.warns(DeprecationWarning):
+        jar.filter_cookies("http://éé.com")
+
+
 async def test_domain_filter_ip_cookie_send() -> None:
     jar = CookieJar()
     cookies = SimpleCookie(