Skip to content

[PR #12136/c0f1513c backport][3.13] Fix AttributeError: 'ClientConnectorCertificateError' object has no attribute '_os_error'.#12147

Merged
Dreamsorcerer merged 1 commit into3.13from
patchback/backports/3.13/c0f1513c37cb145b2618aeffd8f58d2f0cf230ab/pr-12136
Feb 27, 2026
Merged

[PR #12136/c0f1513c backport][3.13] Fix AttributeError: 'ClientConnectorCertificateError' object has no attribute '_os_error'.#12147
Dreamsorcerer merged 1 commit into3.13from
patchback/backports/3.13/c0f1513c37cb145b2618aeffd8f58d2f0cf230ab/pr-12136

Conversation

@patchback
Copy link
Contributor

@patchback patchback bot commented Feb 26, 2026

This is a backport of PR #12136 as merged into master (c0f1513).

What do these changes do?

ClientConnectorCertificateError is a subclass of ClientConnectorError and should have all of its attributes (Liskov substitution principle). However, when I try to access the os_error attribute in my exception handler, I get the following exception:

AttributeError: 'ClientConnectorCertificateError' object has no attribute '_os_error'.

Are there changes in behavior for the user?

Users that use hasattr(e, 'os_error') to ensure that e is not an instance of ClientConnectorCertificateError (or its subclasses), will have their code broken.

Is it a substantial burden for the maintainers to support this?

There should be none.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 26, 2026

Merging this PR will not alter performance

✅ 59 untouched benchmarks


Comparing patchback/backports/3.13/c0f1513c37cb145b2618aeffd8f58d2f0cf230ab/pr-12136 (3acb89c) with 3.13 (57ac25b)

Open in CodSpeed

@Dreamsorcerer Dreamsorcerer merged commit 5d922ee into 3.13 Feb 27, 2026
41 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.13/c0f1513c37cb145b2618aeffd8f58d2f0cf230ab/pr-12136 branch February 27, 2026 00:28
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (57ac25b) to head (3acb89c).
⚠️ Report is 2 commits behind head on 3.13.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.13   #12147   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         128      128           
  Lines       44685    44695   +10     
  Branches     2430     2431    +1     
=======================================
+ Hits        43919    43929   +10     
  Misses        590      590           
  Partials      176      176           
Flag Coverage Δ
CI-GHA 98.16% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.92% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.60% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.17% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.71% <100.00%> (+<0.01%) ⬆️
Py-3.10.19 97.19% <100.00%> (-0.01%) ⬇️
Py-3.11.14 97.39% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.90% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 96.99% <100.00%> (+<0.01%) ⬆️
Py-3.12.12 97.48% <100.00%> (+<0.01%) ⬆️
Py-3.13.11 ?
Py-3.13.12 97.70% <100.00%> (+0.73%) ⬆️
Py-3.14.2 ?
Py-3.14.3 97.62% <100.00%> (+0.73%) ⬆️
Py-3.14.3t 96.72% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.60% <100.00%> (+<0.01%) ⬆️
Py-3.9.25 97.08% <100.00%> (+<0.01%) ⬆️
Py-pypy3.11.13-7.3.20 96.78% <100.00%> (+<0.01%) ⬆️
VM-macos 97.17% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.92% <100.00%> (+<0.01%) ⬆️
VM-windows 95.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants