[PR #12136/c0f1513c backport][3.14] Fix AttributeError: 'ClientConnectorCertificateError' object has no attribute '_os_error'.

[patchback]

This is a backport of PR #12136 as merged into master (c0f1513).

What do these changes do?

ClientConnectorCertificateError is a subclass of ClientConnectorError and should have all of its attributes (Liskov substitution principle). However, when I try to access the os_error attribute in my exception handler, I get the following exception:

AttributeError: 'ClientConnectorCertificateError' object has no attribute '_os_error'.

Are there changes in behavior for the user?

Users that use hasattr(e, 'os_error') to ensure that e is not an instance of ClientConnectorCertificateError (or its subclasses), will have their code broken.

Is it a substantial burden for the maintainers to support this?

There should be none.

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES/ folder

  • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

  • if you don't have an issue number, change it to the pull request
    number after creating the PR

    • .bugfix: A bug fix for something the maintainers deemed an
      improper undesired behavior that got corrected to match
      pre-agreed expectations.
    • .feature: A new behavior, public APIs. That sort of stuff.
    • .deprecation: A declaration of future API removals and breaking
      changes in behavior.
    • .breaking: When something public is removed in a breaking way.
      Could be deprecated in an earlier release.
    • .doc: Notable updates to the documentation structure or build
      process.
    • .packaging: Notes for downstreams about unobvious side effects
      and tooling. Changes in the test invocation considerations and
      runtime assumptions.
    • .contrib: Stuff that affects the contributor experience. e.g.
      Running tests, building the docs, setting up the development
      environment.
    • .misc: Changes that are hard to assign to any of the above
      categories.

  • Make sure to use full sentences with correct case and punctuation,
    for example:

    Fixed issue with non-ascii contents in doctest text files
    -- by :user:`contributor-gh-handle`.

    Use the past tense or the present tense a non-imperative mood,
    referring to what's changed compared to the last released version
    of this project.

[codspeed-hq]

Merging this PR will not alter performance

✅ 59 untouched benchmarks

---

_{Comparing patchback/backports/3.14/c0f1513c37cb145b2618aeffd8f58d2f0cf230ab/pr-12136 (24e32f6) with 3.14 (26917a2)¹}

Footnotes

1. No successful run was found on 3.14 (08c6270) during the generation of this report, so 26917a2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.26%. Comparing base (26917a2) to head (24e32f6).
⚠️ Report is 6 commits behind head on 3.14.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             3.14   #12148      +/-   ##
==========================================
- Coverage   98.26%   98.26%   -0.01%     
==========================================
  Files         129      129              
  Lines       45664    45674      +10     
  Branches     2472     2473       +1     
==========================================
+ Hits        44871    44880       +9     
  Misses        612      612              
- Partials      181      182       +1     

Flag	Coverage Δ
CI-GHA	98.13% <100.00%> (-0.01%)	⬇️
OS-Linux	97.90% <100.00%> (-0.01%)	⬇️
OS-Windows	95.62% <100.00%> (+<0.01%)	⬆️
OS-macOS	97.17% <100.00%> (+<0.01%)	⬆️
Py-3.10.11	96.70% <100.00%> (+<0.01%)	⬆️
Py-3.10.19	97.18% <100.00%> (+<0.01%)	⬆️
Py-3.11.14	97.41% <100.00%> (+<0.01%)	⬆️
Py-3.11.9	96.94% <100.00%> (+<0.01%)	⬆️
Py-3.12.10	97.02% <100.00%> (+<0.01%)	⬆️
Py-3.12.12	97.50% <100.00%> (+<0.01%)	⬆️
Py-3.13.11	?
Py-3.13.12	97.73% <100.00%> (+0.72%)	⬆️
Py-3.14.2	?
Py-3.14.3	97.68% <100.00%> (+0.71%)	⬆️
Py-3.14.3t	96.79% <100.00%> (-0.01%)	⬇️
Py-pypy3.11.13-7.3.20	96.83% <100.00%> (+<0.01%)	⬆️
VM-macos	97.17% <100.00%> (+<0.01%)	⬆️
VM-ubuntu	97.90% <100.00%> (-0.01%)	⬇️
VM-windows	95.62% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.