Strict typing (#703)

Author: Dreamsorcerer

.mypy.ini

@@ -1,18 +1,29 @@
 [mypy]
-files =
-  aiosignal/
-follow_imports = silent
-strict_optional = True
-warn_redundant_casts = True
-
-# uncomment next lines
-# to enable strict mypy mode
-#
+files = aiosignal, tests
 check_untyped_defs = True
+follow_imports_for_stubs = True
+disallow_any_decorated = True
 disallow_any_generics = True
+disallow_any_unimported = True
+disallow_incomplete_defs = True
+disallow_subclassing_any = True
+disallow_untyped_calls = True
+disallow_untyped_decorators = True
 disallow_untyped_defs = True
+# TODO(PY312): explicit-override
+enable_error_code = deprecated, ignore-without-code, possibly-undefined, redundant-expr, redundant-self, truthy-bool, truthy-iterable, unused-awaitable
+extra_checks = True
+follow_untyped_imports = True
+implicit_reexport = False
+no_implicit_optional = True
+pretty = True
+show_column_numbers = True
+show_error_codes = True
+show_error_code_links = True
+strict_bytes = True
+strict_equality = True
+warn_incomplete_stub = True
+warn_redundant_casts = True
+warn_return_any = True
+warn_unreachable = True
 warn_unused_ignores = True
-
-
-[mypy-pytest]
-ignore_missing_imports = true

.pre-commit-config.yaml

@@ -61,14 +61,15 @@ repos:
   - id: check-github-actions
 
 - repo: https://github.com/pre-commit/mirrors-mypy.git
-  rev: v1.14.1
+  rev: v1.16.0
   hooks:
   - id: mypy
     alias: mypy-py313
     name: MyPy, for Python 3.13
     additional_dependencies:
     - frozenlist  # runtime dependency
     - lxml  # dep of `--txt-report`, `--cobertura-xml-report` & `--html-report`
+    - pytest
     args:
     - --python-version=3.13
     - --any-exprs-report=.tox/.tmp/.test-results/mypy--py-3.13
@@ -85,6 +86,7 @@ repos:
     additional_dependencies:
     - frozenlist  # runtime dependency
     - lxml  # dep of `--txt-report`, `--cobertura-xml-report` & `--html-report`
+    - pytest
     args:
     - --python-version=3.11
     - --any-exprs-report=.tox/.tmp/.test-results/mypy--py-3.11
@@ -101,6 +103,7 @@ repos:
     additional_dependencies:
     - frozenlist  # runtime dependency
     - lxml  # dep of `--txt-report`, `--cobertura-xml-report` & `--html-report`
+    - pytest
     args:
     - --python-version=3.9
     - --any-exprs-report=.tox/.tmp/.test-results/mypy--py-3.9

tests/test_signals.py

@@ -1,10 +1,16 @@
 import re
+import sys
 from unittest import mock
 
 import pytest
 
 from aiosignal import Signal
 
+if sys.version_info >= (3, 11):
+    from typing import Unpack
+else:
+    from typing_extensions import Unpack
+
 
 class Owner:
     def __repr__(self) -> str:
@@ -16,10 +22,20 @@ def owner() -> Owner:
     return Owner()
 
 
+async def test_signal_positional_args(owner: Owner) -> None:
+    async def callback(a: int, b: str) -> None:
+        return
+
+    signal = Signal[int, str](owner)
+    signal.append(callback)
+    signal.freeze()
+    await signal.send(42, "foo")
+
+
 async def test_add_signal_handler_not_a_callable(owner: Owner) -> None:
     callback = True
     signal = Signal(owner)
-    signal.append(callback)
+    signal.append(callback)  # type: ignore[arg-type]
     signal.freeze()
     with pytest.raises(TypeError):
         await signal.send()
@@ -31,7 +47,7 @@ async def test_function_signal_dispatch_kwargs(owner: Owner) -> None:
 
     callback_mock = mock.Mock()
 
-    async def callback(**kwargs):
+    async def callback(**kwargs: object) -> None:
         callback_mock(**kwargs)
 
     signal.append(callback)
@@ -42,20 +58,19 @@ async def callback(**kwargs):
 
 
 async def test_function_signal_dispatch_args_kwargs(owner: Owner) -> None:
-    signal = Signal(owner)
-    args = {"a", "b"}
+    signal = Signal[Unpack[tuple[str, ...]]](owner)
     kwargs = {"foo": 1, "bar": 2}
 
     callback_mock = mock.Mock()
 
-    async def callback(*args, **kwargs):
+    async def callback(*args: str, **kwargs: object) -> None:
         callback_mock(*args, **kwargs)
 
     signal.append(callback)
     signal.freeze()
 
-    await signal.send(*args, **kwargs)
-    callback_mock.assert_called_once_with(*args, **kwargs)
+    await signal.send("a", "b", **kwargs)
+    callback_mock.assert_called_once_with("a", "b", **kwargs)
 
 
 async def test_non_coroutine(owner: Owner) -> None:
@@ -130,7 +145,7 @@ async def test_cannot_send_non_frozen_signal(owner: Owner) -> None:
 
     callback_mock = mock.Mock()
 
-    async def callback(**kwargs):
+    async def callback(**kwargs: object) -> None:
         callback_mock(**kwargs)  # pragma: no cover  # mustn't be called
 
     signal.append(callback)