Optimize C version of getall() (#1212)

asvetlov · web-flow · commit acdd2d169b80 · 2025-06-27T08:51:24.000+02:00
diff --git a/CHANGES/1212.feature.rst b/CHANGES/1212.feature.rst
@@ -0,0 +1 @@
+C implementation of :class:`multidict.MultiDict.getall` now is slightly faster if it returns nothing -- by :user:`asvetlov`.
diff --git a/multidict/_multilib/hashtable.h b/multidict/_multilib/hashtable.h
@@ -903,7 +903,10 @@ md_get_all(MultiDictObject *md, PyObject *key, PyObject **ret)
         goto fail;
     }
 
-    md_finder_cleanup(&finder);
+    if (*ret != NULL) {
+        // there is no need to restore hashes if none was marked
+        md_finder_cleanup(&finder);
+    }
     Py_DECREF(identity);
     return *ret != NULL;
 fail:

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+C implementation of :class:`multidict.MultiDict.getall` now is slightly faster if it returns nothing -- by :user:`asvetlov`.