Skip to content

Commit ec58b30

Browse files
authored
Stable benchmarks, fifth attempt (#1209)
See #1201 for details The PR increases the keys space. The tested idea is: if instability is because of colliding keys, increasing the number of keys reduces the chance of getting a very bad or very good test setup. The test setup becomes 'neutral' with more or less predictable execution time.
1 parent bae27b3 commit ec58b30

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

tests/test_multidict_benchmarks.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ def test_multidict_getall_str_hit(
292292
benchmark: BenchmarkFixture, any_multidict_class: Type[MultiDict[str]]
293293
) -> None:
294294
md = any_multidict_class(
295-
(f"key{j}", str(f"{i}-{j}")) for i in range(20) for j in range(5)
295+
(f"key{j}", str(f"{i}-{j}")) for i in range(100) for j in range(10)
296296
)
297297

298298
keys = set(md.keys())
@@ -308,7 +308,7 @@ def test_multidict_getall_str_miss(
308308
benchmark: BenchmarkFixture, any_multidict_class: Type[MultiDict[str]]
309309
) -> None:
310310
md = any_multidict_class(
311-
(f"key{j}", str(f"{i}-{j}")) for i in range(20) for j in range(5)
311+
(f"key{j}", str(f"{i}-{j}")) for i in range(100) for j in range(10)
312312
)
313313

314314
keys = {f"{key}-miss" for key in md.keys()}
@@ -326,8 +326,8 @@ def test_cimultidict_getall_istr_hit(
326326
) -> None:
327327
md = case_insensitive_multidict_class(
328328
(f"key{j}", case_insensitive_str_class(f"{i}-{j}"))
329-
for i in range(20)
330-
for j in range(5)
329+
for i in range(100)
330+
for j in range(10)
331331
)
332332

333333
keys = set(md.keys())
@@ -346,8 +346,8 @@ def test_cimultidict_getall_istr_miss(
346346
) -> None:
347347
md = case_insensitive_multidict_class(
348348
(case_insensitive_str_class(f"key{j}"), case_insensitive_str_class(f"{i}-{j}"))
349-
for i in range(20)
350-
for j in range(5)
349+
for i in range(100)
350+
for j in range(10)
351351
)
352352

353353
keys = {case_insensitive_str_class(f"{key}-miss") for key in md.keys()}

0 commit comments

Comments
 (0)