Skip to content

Commit 57a85c1

Browse files
authored
[BUG] explicit encoding for file open to avoid failures on windows (#685)
## Change(s) modified tests in `src\tests\connectors\zenodo\mock_zenodo.py` to explicitly sprcify the encoding `encoding="utf-8"` for file open. Change Type: Fixed ## How to Test run this command: ```bash pytest src/tests/ ``` before this fix, there would be a encoding error thrown (in windows only. linux does not have this issue) ## Related Issues #683
1 parent 47cb387 commit 57a85c1

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/tests/connectors/zenodo/mock_zenodo.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55

66
TOKEN_EXPIRATION_DATETIME = "2024-02-08T17:40:07Z"
77

8-
with open(path_test_resources() / "connectors" / "zenodo" / "list_records_1.xml", "r") as f:
8+
with open(path_test_resources() / "connectors" / "zenodo" / "list_records_1.xml", "r", encoding="utf-8") as f:
99
records_list_1 = f.read()
1010

11-
with open(path_test_resources() / "connectors" / "zenodo" / "list_records_2.xml", "r") as f:
11+
with open(path_test_resources() / "connectors" / "zenodo" / "list_records_2.xml", "r", encoding="utf-8") as f:
1212
records_list_2 = f.read()
1313

1414

@@ -77,7 +77,7 @@ def response_with_no_records(mocked_requests: responses.RequestsMock):
7777

7878

7979
def record_response(mocked_requests: responses.RequestsMock, id_: int):
80-
with open(path_test_resources() / "connectors" / "zenodo" / f"{id_}.json", "r") as f:
80+
with open(path_test_resources() / "connectors" / "zenodo" / f"{id_}.json", "r", encoding="utf-8") as f:
8181
body = f.read()
8282
mocked_requests.add(
8383
responses.GET, f"https://zenodo.org/api/records/{id_}/files", body=body, status=200

0 commit comments

Comments
 (0)