Do not allow uploading of binary_blob in distribution field. (#610)

Patch also other distributions

Author: PGijsbers

alembic/alembic/versions/fabaaad1cf1f_make_content_url_optional_and_add_image_.py

@@ -36,6 +36,15 @@
     "team",
 ]
 
+assets_with_distributions = [
+    "case_study",
+    "dataset",
+    "experiment",
+    "computational_asset",
+    "ml_model",
+    "publication",
+]
+
 
 def upgrade() -> None:
     for asset_type in assets_with_media:
@@ -51,6 +60,12 @@ def upgrade() -> None:
             column=sa.Column("binary_blob", sa.LargeBinary(), nullable=True),
         )
 
+    for asset_type in assets_with_distributions:
+        op.add_column(
+            table_name=f"distribution_{asset_type}",
+            column=sa.Column("binary_blob", sa.LargeBinary(), nullable=True),
+        )
+
 
 def downgrade() -> None:
     for asset_type in assets_with_media:
@@ -62,3 +77,6 @@ def downgrade() -> None:
         )
 
         op.drop_column(f"media_{asset_type}", "binary_blob")
+
+    for asset_type in assets_with_distributions:
+        op.drop_column(f"distribution_{asset_type}", "binary_blob")

src/routers/resource_router.py

@@ -871,12 +871,14 @@ def _raise_error_on_invalid_schema(possible_schemas, schema):
 
 
 def _raise_if_contains_binary_blob(item):
-    if not hasattr(item, "media") or not (media := getattr(item, "media")):
-        return
+    distributions = []
+    if hasattr(item, "distribution") and (distribution := getattr(item, "distribution")):
+        distributions += distribution
+    if hasattr(item, "media") and (media := getattr(item, "media")):
+        distributions += media
 
-    for item in media:
-        if isinstance(item, Distribution) and item.binary_blob:
-            raise HTTPException(
-                status_code=HTTPStatus.BAD_REQUEST,
-                detail="Setting `binary_blob` is forbidden. Consider using `content_url` instead.",
-            )
+    if any((isinstance(item, Distribution) and item.binary_blob) for item in distributions):
+        raise HTTPException(
+            status_code=HTTPStatus.BAD_REQUEST,
+            detail="Setting `binary_blob` is forbidden. Consider using `content_url` instead.",
+        )