Skip to content

Commit de3cbb5

Browse files
authored
Set defaults for ADMIN and REVIEWER roles (#645)
Log keycloak role environment variables
1 parent d4f60df commit de3cbb5

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/authentication.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@
3535

3636
oidc = OpenIdConnect(openIdConnectUrl=KEYCLOAK_CONFIG.get("openid_connect_url"), auto_error=False)
3737

38-
REVIEWER_ROLE = os.getenv("REVIEWER_ROLE_NAME")
39-
ADMIN_ROLE = os.getenv("ADMIN_ROLE_NAME")
38+
REVIEWER_ROLE = os.getenv("REVIEWER_ROLE_NAME", "review_aiod_resources")
39+
ADMIN_ROLE = os.getenv("ADMIN_ROLE_NAME", "admin_aiod_resources")
4040
client_secret = os.getenv("KEYCLOAK_CLIENT_SECRET")
4141

4242
keycloak_openid = KeycloakOpenID(

src/config.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import copy
22
import logging
3+
import os
34
import pathlib
45
import tomllib
56
from collections import deque
@@ -12,11 +13,13 @@
1213
_log_lines: deque[tuple[int, str]] = deque()
1314
logger = logging.getLogger(__file__)
1415

16+
_log_lines.append((logging.INFO, f"REVIEWER_ROLE_NAME={os.getenv('REVIEWER_ROLE_NAME')}"))
17+
_log_lines.append((logging.INFO, f"ADMIN_ROLE_NAME={os.getenv('ADMIN_ROLE_NAME')}"))
18+
1519
default_config_path = pathlib.Path(__file__).parent / "config.default.toml"
1620
with open(default_config_path, "rb") as fh:
1721
DEFAULT_CONFIG = tomllib.load(fh)
1822
_log_lines.append((logging.INFO, f"Loaded default configuration from {default_config_path}"))
19-
logger.info("Actually Foo")
2023

2124
OVERRIDE_CONFIG_PATH = pathlib.Path(__file__).parent / "config.override.toml"
2225
if OVERRIDE_CONFIG_PATH.exists() and OVERRIDE_CONFIG_PATH.is_file():

0 commit comments

Comments
 (0)