-
Notifications
You must be signed in to change notification settings - Fork 79
Open
Description
Problem
The AIBuilder MLModel connector has partial mapping and a security concern:
version,distribution, andlicenseare marked TODO and are not fully mapped.- Connector requests include
apiTokenin query URLs, and URL handling risks exposing sensitive token values in error paths/logging. - The connector currently underuses available artifact metadata from AIBuilder responses.
Affected files
src/connectors/aibuilder/aibuilder_mlmodel_connector.pysrc/connectors/aibuilder/aibuilder_mappings.pysrc/tests/connectors/aibuilder/test_aibuilder_mlmodel_connector.py
Expected behavior
versionshould be mapped when available (fallback from artifacts if needed).distributionshould be built from AIBuilderartifacts.licenseshould be mapped when provided.- token values must never appear in stored URLs or error messages.
- connector tests should verify all the above.
Proposed solution
- Add missing mapping keys in
aibuilder_mappings.py. - Implement robust distribution conversion from
artifacts->RunnableDistribution. - Use a public token-free
same_asURL for saved resources. - Sanitize token from error URL messages.
- Add/update tests to assert:
- mapped
version - mapped
distribution - token-free
same_as - sanitized error messages
- mapped
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels