Add support to send whole file using "--data" argument

[devkdas]

Hai,

I am trying to upload file using aioquic(using below command) and not able to get how to do
and instead getting file with data as "Method Not Allowed" while using below command

I didnt made any changes to http3_client.py or http3_server.py

(python3 /root/aioquic/examples/http3_client.py --ca-certs /root/aioquic/tests/pycacert.pem -v https://1.2.3.4:4433/new.pdf --output-dir /tmp/ --data new.pdf)

Do i need to place the file which i wanted to upload under any speific folder like /aioquic/examples/

Could anyone please help me to send file using aioquic http3_client.py "--data" argument.

Looking forward for reply

Thank you.

[jlaine]

If you examine http3_client.py you'll see that --data is literally going to send "new.pdf" as a string to the server, not the contents of your file. I would accept a PR which does two things:

• make perform_http_request take data as bytes not str
• supports a syntax like cURL --data @filename to send the contents of a file if the argument starts with "@"

However, I'm NOT convinced this is the actual cause of your problem. Are you sure your server expects a POST and not a PUT?

[devkdas]

Thank you replying back.

yes yes,my server excepts POST request and running http3_server.py from examples

Even if i replace POST with PUT same thing is happening and will try to implement what you have said.

once again Thank you for confirming

[devkdas]

Sorry @jlaine,
I have a very limited knowledge about Python and if you were asking about ASGI application(ASGI handler),i am currently using default application(demo.py),I didnt made any changes to any of your code

I dont think there is any issue with your code and here is the output of your code while running with --data argument

SERVER :-
root@ubuntu:~# python3 aioquic/examples/http3_server.py --certificate aioquic/tests/ssl_cert.pem --private-key aioquic/tests/ssl_key.pem -v
2022-07-18 04:05:31,078 DEBUG asyncio Using selector: EpollSelector
2022-07-18 04:05:38,379 DEBUG quic [0e8824d6b42a6b74] Network path ('::ffff:127.0.0.1', 52292, 0, 0) discovered
2022-07-18 04:05:38,382 DEBUG quic [0e8824d6b42a6b74] QuicConnectionState.FIRSTFLIGHT -> QuicConnectionState.CONNECTED
2022-07-18 04:05:38,389 DEBUG quic [0e8824d6b42a6b74] TLS State.SERVER_EXPECT_CLIENT_HELLO -> State.SERVER_EXPECT_FINISHED
2022-07-18 04:05:38,392 DEBUG quic [0e8824d6b42a6b74] Discarding epoch Epoch.INITIAL
2022-07-18 04:05:38,392 DEBUG quic [0e8824d6b42a6b74] Network path ('::ffff:127.0.0.1', 52292, 0, 0) validated by handshake
2022-07-18 04:05:38,421 DEBUG quic [0e8824d6b42a6b74] Loss detection triggered
2022-07-18 04:05:38,422 DEBUG quic [0e8824d6b42a6b74] Scheduled CRYPTO data for retransmission
2022-07-18 04:05:38,425 DEBUG quic [0e8824d6b42a6b74] TLS State.SERVER_EXPECT_FINISHED -> State.SERVER_POST_HANDSHAKE
2022-07-18 04:05:38,425 DEBUG quic [0e8824d6b42a6b74] Discarding epoch Epoch.HANDSHAKE
2022-07-18 04:05:38,425 INFO quic [0e8824d6b42a6b74] ALPN negotiated protocol h3
2022-07-18 04:05:38,425 DEBUG quic [0e8824d6b42a6b74] Stream 2 created by peer
2022-07-18 04:05:38,425 DEBUG quic [0e8824d6b42a6b74] Stream 6 created by peer
2022-07-18 04:05:38,425 DEBUG quic [0e8824d6b42a6b74] Stream 10 created by peer
2022-07-18 04:05:38,426 DEBUG quic [0e8824d6b42a6b74] Decryption key is not available
2022-07-18 04:05:38,426 DEBUG quic [0e8824d6b42a6b74] Stream 0 created by peer
2022-07-18 04:05:38,426 INFO quic [0e8824d6b42a6b74] HTTP request POST /
2022-07-18 04:05:38,434 INFO quic [0e8824d6b42a6b74] Connection close received (code 0x100, reason )
2022-07-18 04:05:38,434 DEBUG quic [0e8824d6b42a6b74] QuicConnectionState.CONNECTED -> QuicConnectionState.DRAINING
2022-07-18 04:05:38,534 DEBUG quic [0e8824d6b42a6b74] Discarding epoch Epoch.ONE_RTT
2022-07-18 04:05:38,535 DEBUG quic [0e8824d6b42a6b74] QuicConnectionState.DRAINING -> QuicConnectionState.TERMINATED

CLIENT:-

root@ubuntu:~# python3 /root/aioquic/examples/http3_client.py --ca-certs /root/aioquic/tests/pycacert.pem -v https://localhost:4433/ -v --data new.pdf
2022-07-18 04:05:38,365 DEBUG asyncio Using selector: EpollSelector
2022-07-18 04:05:38,377 DEBUG quic [0e8824d6b42a6b74] TLS State.CLIENT_HANDSHAKE_START -> State.CLIENT_EXPECT_SERVER_HELLO
2022-07-18 04:05:38,390 DEBUG quic [0e8824d6b42a6b74] QuicConnectionState.FIRSTFLIGHT -> QuicConnectionState.CONNECTED
2022-07-18 04:05:38,391 DEBUG quic [0e8824d6b42a6b74] TLS State.CLIENT_EXPECT_SERVER_HELLO -> State.CLIENT_EXPECT_ENCRYPTED_EXTENSIONS
2022-07-18 04:05:38,391 DEBUG quic [0e8824d6b42a6b74] TLS State.CLIENT_EXPECT_ENCRYPTED_EXTENSIONS -> State.CLIENT_EXPECT_CERTIFICATE_REQUEST_OR_CERTIFICATE
2022-07-18 04:05:38,391 DEBUG quic [0e8824d6b42a6b74] Discarding epoch Epoch.INITIAL
2022-07-18 04:05:38,392 DEBUG quic [0e8824d6b42a6b74] TLS State.CLIENT_EXPECT_CERTIFICATE_REQUEST_OR_CERTIFICATE -> State.CLIENT_EXPECT_CERTIFICATE_VERIFY
2022-07-18 04:05:38,422 DEBUG quic [0e8824d6b42a6b74] TLS State.CLIENT_EXPECT_CERTIFICATE_VERIFY -> State.CLIENT_EXPECT_FINISHED
2022-07-18 04:05:38,423 DEBUG quic [0e8824d6b42a6b74] TLS State.CLIENT_EXPECT_FINISHED -> State.CLIENT_POST_HANDSHAKE
2022-07-18 04:05:38,423 INFO quic [0e8824d6b42a6b74] ALPN negotiated protocol h3
2022-07-18 04:05:38,424 INFO client New session ticket received
2022-07-18 04:05:38,424 DEBUG quic [0e8824d6b42a6b74] Stream 3 created by peer
2022-07-18 04:05:38,424 DEBUG quic [0e8824d6b42a6b74] Stream 7 created by peer
2022-07-18 04:05:38,424 DEBUG quic [0e8824d6b42a6b74] Stream 11 created by peer
2022-07-18 04:05:38,424 INFO quic [0e8824d6b42a6b74] Duplicate CRYPTO data received for epoch Epoch.HANDSHAKE
2022-07-18 04:05:38,424 INFO quic [0e8824d6b42a6b74] Duplicate CRYPTO data received for epoch Epoch.ONE_RTT
2022-07-18 04:05:38,426 DEBUG quic [0e8824d6b42a6b74] Discarding epoch Epoch.HANDSHAKE
2022-07-18 04:05:38,433 DEBUG quic [0e8824d6b42a6b74] Stream 0 discarded
2022-07-18 04:05:38,433 INFO client Response received for POST / : 18 bytes in 0.0 s (0.017 Mbps)
2022-07-18 04:05:38,433 INFO quic [0e8824d6b42a6b74] Connection close sent (code 0x100, reason )
2022-07-18 04:05:38,434 DEBUG quic [0e8824d6b42a6b74] QuicConnectionState.CONNECTED -> QuicConnectionState.CLOSING
2022-07-18 04:05:38,591 DEBUG quic [0e8824d6b42a6b74] Discarding epoch Epoch.ONE_RTT
2022-07-18 04:05:38,591 DEBUG quic [0e8824d6b42a6b74] QuicConnectionState.CLOSING -> QuicConnectionState.TERMINATED

SERVER:-
root@ubuntu:~# python3 aioquic/examples/http3_server.py --certificate aioquic/tests/ssl_cert.pem --private-key aioquic/tests/ssl_key.pem -v
2022-07-18 04:06:59,287 DEBUG asyncio Using selector: EpollSelector
2022-07-18 04:07:06,883 DEBUG quic [9470c989fe7a3a29] Network path ('::ffff:127.0.0.1', 49719, 0, 0) discovered
2022-07-18 04:07:06,884 DEBUG quic [9470c989fe7a3a29] QuicConnectionState.FIRSTFLIGHT -> QuicConnectionState.CONNECTED
2022-07-18 04:07:06,891 DEBUG quic [9470c989fe7a3a29] TLS State.SERVER_EXPECT_CLIENT_HELLO -> State.SERVER_EXPECT_FINISHED
2022-07-18 04:07:06,894 DEBUG quic [9470c989fe7a3a29] Discarding epoch Epoch.INITIAL
2022-07-18 04:07:06,894 DEBUG quic [9470c989fe7a3a29] Network path ('::ffff:127.0.0.1', 49719, 0, 0) validated by handshake
2022-07-18 04:07:06,924 DEBUG quic [9470c989fe7a3a29] Loss detection triggered
2022-07-18 04:07:06,924 DEBUG quic [9470c989fe7a3a29] Scheduled CRYPTO data for retransmission
2022-07-18 04:07:06,929 DEBUG quic [9470c989fe7a3a29] TLS State.SERVER_EXPECT_FINISHED -> State.SERVER_POST_HANDSHAKE
2022-07-18 04:07:06,929 DEBUG quic [9470c989fe7a3a29] Discarding epoch Epoch.HANDSHAKE
2022-07-18 04:07:06,930 INFO quic [9470c989fe7a3a29] ALPN negotiated protocol h3
2022-07-18 04:07:06,930 DEBUG quic [9470c989fe7a3a29] Stream 2 created by peer
2022-07-18 04:07:06,931 DEBUG quic [9470c989fe7a3a29] Stream 6 created by peer
2022-07-18 04:07:06,931 DEBUG quic [9470c989fe7a3a29] Stream 10 created by peer
2022-07-18 04:07:06,933 DEBUG quic [9470c989fe7a3a29] Decryption key is not available
2022-07-18 04:07:06,933 DEBUG quic [9470c989fe7a3a29] Stream 0 created by peer
2022-07-18 04:07:06,934 INFO quic [9470c989fe7a3a29] HTTP request POST /new.pdf
2022-07-18 04:07:06,943 INFO quic [9470c989fe7a3a29] Connection close received (code 0x100, reason )
2022-07-18 04:07:06,943 DEBUG quic [9470c989fe7a3a29] QuicConnectionState.CONNECTED -> QuicConnectionState.DRAINING
2022-07-18 04:07:07,075 DEBUG quic [9470c989fe7a3a29] Discarding epoch Epoch.ONE_RTT
2022-07-18 04:07:07,075 DEBUG quic [9470c989fe7a3a29] QuicConnectionState.DRAINING -> QuicConnectionState.TERMINATED

CLIENT:-
root@ubuntu:~# python3 /root/aioquic/examples/http3_client.py --ca-certs /root/aioquic/tests/pycacert.pem -v https://localhost:4433/new.pdf -v --data new.pdf
2022-07-18 04:07:06,873 DEBUG asyncio Using selector: EpollSelector
2022-07-18 04:07:06,882 DEBUG quic [9470c989fe7a3a29] TLS State.CLIENT_HANDSHAKE_START -> State.CLIENT_EXPECT_SERVER_HELLO
2022-07-18 04:07:06,892 DEBUG quic [9470c989fe7a3a29] QuicConnectionState.FIRSTFLIGHT -> QuicConnectionState.CONNECTED
2022-07-18 04:07:06,893 DEBUG quic [9470c989fe7a3a29] TLS State.CLIENT_EXPECT_SERVER_HELLO -> State.CLIENT_EXPECT_ENCRYPTED_EXTENSIONS
2022-07-18 04:07:06,893 DEBUG quic [9470c989fe7a3a29] TLS State.CLIENT_EXPECT_ENCRYPTED_EXTENSIONS -> State.CLIENT_EXPECT_CERTIFICATE_REQUEST_OR_CERTIFICATE
2022-07-18 04:07:06,894 DEBUG quic [9470c989fe7a3a29] Discarding epoch Epoch.INITIAL
2022-07-18 04:07:06,894 DEBUG quic [9470c989fe7a3a29] TLS State.CLIENT_EXPECT_CERTIFICATE_REQUEST_OR_CERTIFICATE -> State.CLIENT_EXPECT_CERTIFICATE_VERIFY
2022-07-18 04:07:06,926 DEBUG quic [9470c989fe7a3a29] TLS State.CLIENT_EXPECT_CERTIFICATE_VERIFY -> State.CLIENT_EXPECT_FINISHED
2022-07-18 04:07:06,927 DEBUG quic [9470c989fe7a3a29] TLS State.CLIENT_EXPECT_FINISHED -> State.CLIENT_POST_HANDSHAKE
2022-07-18 04:07:06,927 INFO quic [9470c989fe7a3a29] ALPN negotiated protocol h3
2022-07-18 04:07:06,927 INFO client New session ticket received
2022-07-18 04:07:06,927 DEBUG quic [9470c989fe7a3a29] Stream 3 created by peer
2022-07-18 04:07:06,927 DEBUG quic [9470c989fe7a3a29] Stream 7 created by peer
2022-07-18 04:07:06,927 DEBUG quic [9470c989fe7a3a29] Stream 11 created by peer
2022-07-18 04:07:06,928 INFO quic [9470c989fe7a3a29] Duplicate CRYPTO data received for epoch Epoch.HANDSHAKE
2022-07-18 04:07:06,928 INFO quic [9470c989fe7a3a29] Duplicate CRYPTO data received for epoch Epoch.ONE_RTT
2022-07-18 04:07:06,932 DEBUG quic [9470c989fe7a3a29] Discarding epoch Epoch.HANDSHAKE
2022-07-18 04:07:06,942 DEBUG quic [9470c989fe7a3a29] Stream 0 discarded
2022-07-18 04:07:06,942 INFO client Response received for POST /new.pdf : 18 bytes in 0.0 s (0.010 Mbps)
2022-07-18 04:07:06,943 INFO quic [9470c989fe7a3a29] Connection close sent (code 0x100, reason )
2022-07-18 04:07:06,943 DEBUG quic [9470c989fe7a3a29] QuicConnectionState.CONNECTED -> QuicConnectionState.CLOSING
2022-07-18 04:07:07,092 DEBUG quic [9470c989fe7a3a29] Discarding epoch Epoch.ONE_RTT
2022-07-18 04:07:07,093 DEBUG quic [9470c989fe7a3a29] QuicConnectionState.CLOSING -> QuicConnectionState.TERMINATED

Hope whatever commands i used to run client ans server are correct and no issue with commands .

[jlaine]

Sorry @jlaine, I have a very limited knowledge about Python and if you were asking about ASGI application(ASGI handler),i am currently using default application(demo.py),I didnt made any changes to any of your code

Well there is your answer: the demo.py does NOT have a /new.pdf route which accepts POST requests, which is why you are getting a 405 response.

[devkdas]

Could you please help me to add route to the demo.py so that I can upload any file using POST request.

Looking forward for your help.

[jlaine]

I'm sorry but this is way out of scope and not specific to HTTP/3. A good starting place is the Starlette documentation since that is the framework used in the demo: https://www.starlette.io/

[devkdas]

Sure

Thank you for your help and sugesstions.

Will have a look and will try to figure it out.

[devkdas]

@jlaine
#582