Skip to content

lines-around-directive rule should replaced with padding-line-between… #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

lines-around-directive rule should replaced with padding-line-between… #2756

wants to merge 1 commit into from

Conversation

HemanthPaila
Copy link

ljharb
ljharb requested changes Apr 2, 2023
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure if your editor is set up to run prettier or any autoformatter, that you disable those - formatters should only be ran on a repo where the repo is set up to use one explicitly

packages/eslint-config-airbnb-base/rules/style.js Outdated
@@ -3,532 +3,645 @@ module.exports = {
// enforce line breaks after opening and before closing array brackets
// https://eslint.org/docs/rules/array-bracket-newline
// TODO: enable? semver-major
'array-bracket-newline': ['off', 'consistent'], // object option alternative: { multiline: true, minItems: 3 }
"array-bracket-newline": ["off", "consistent"], // object option alternative: { multiline: true, minItems: 3 }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the unrelated and incorrect formatting (this guide requires JS to use single quotes)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @ljharb

@HemanthPaila
Copy link
Author

sir i am closing now and i will make PR again.

@HemanthPaila HemanthPaila reopened this Apr 2, 2023
@ljharb
Copy link
Collaborator

ljharb commented Apr 2, 2023

Please reuse this one, and do not create a new one.

@ljharb ljharb reopened this Apr 2, 2023
@ljharb ljharb marked this pull request as draft April 2, 2023 06:13
@ljharb ljharb force-pushed the HemanthPaila-Fixed branch from da606cc to 1764d53 Compare April 2, 2023 06:16
This was referenced Apr 2, 2023
Draft
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

+1 more reviewer

@anandfresh anandfresh anandfresh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HemanthPaila @ljharb @anandfresh