Skip to content

Added cross platform compatibility #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added cross platform compatibility #3114

wants to merge 3 commits into from
+3 −2

Conversation

adityashibu
Copy link

This pull request includes a small change to the package.json file. The change updates the postinstall script to use npx rimraf instead of rm -rf for removing the markdownlint directory.

Ensures cross platform compatibility for Windows and Linux based systems

ljharb
ljharb requested changes Apr 3, 2025
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, this only improves cross-platform usage for developers of this package, which is currently just one person who doesn't use windows.

@adityashibu adityashibu requested a review from ljharb April 3, 2025 15:07
@adityashibu
Copy link
Author

@ljharb any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb Awaiting requested review from ljharb

1 more reviewer

@anandfresh anandfresh anandfresh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adityashibu @ljharb @anandfresh