Skip to content

Commit 87ff628

Browse files
committed
Revert changes to getSketchVersion()
1 parent f143562 commit 87ff628

File tree

5 files changed

+11
-13
lines changed

5 files changed

+11
-13
lines changed

β€Ž__tests__/jest/sharedStyles/TextStyles.tsβ€Ž

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ beforeEach(() => {
88
jest.resetModules();
99

1010
jest.mock('../../../src/utils/getSketchVersion', () => ({
11-
__esModule: true,
12-
default: jest.fn(() => '51'),
11+
getSketchVersion: jest.fn(() => 51),
1312
}));
1413

1514
TextStyles = require('../../../src/sharedStyles/TextStyles');

β€Žsrc/Platform.tsβ€Ž

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
1-
import getSketchVersion from './utils/getSketchVersion';
2-
31
const Platform = {
42
OS: 'sketch',
5-
Version: getSketchVersion(),
3+
Version: 1,
64
select: (obj: { sketch: any }) => obj.sketch,
75
};
86

β€Žsrc/sharedStyles/TextStyles.tsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
TextStyle,
77
PlatformBridge,
88
} from '../types';
9-
import getSketchVersion from '../utils/getSketchVersion';
9+
import { getSketchVersion } from '../utils/getSketchVersion';
1010
import isRunningInSketch from '../utils/isRunningInSketch';
1111
import hashStyle from '../utils/hashStyle';
1212
import { getDocument } from '../utils/getDocument';
@@ -65,7 +65,7 @@ const TextStyles = (getDefaultBridge: () => PlatformBridge) => ({
6565

6666
const doc = getDocument(document);
6767

68-
if (isRunningInSketch() && doc != null && parseInt(getSketchVersion()) < 50) {
68+
if (isRunningInSketch() && doc != null && getSketchVersion() < 50) {
6969
doc.showMessage('πŸ’Ž Requires Sketch 50+ πŸ’Ž');
7070
return {};
7171
}
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
export default function getSketchVersion(): string {
2-
return typeof NSBundle !== 'undefined'
3-
? NSBundle.mainBundle().infoDictionary().CFBundleShortVersionString
4-
: '';
1+
export function getSketchVersion(): number | 'NodeJS' {
2+
if (typeof NSBundle !== 'undefined') {
3+
return parseFloat(NSBundle.mainBundle().infoDictionary().CFBundleShortVersionString);
4+
}
5+
return 'NodeJS';
56
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import getSketchVersion from './getSketchVersion';
1+
import { getSketchVersion } from './getSketchVersion';
22

33
export default function isRunningInSketch() {
4-
return getSketchVersion() !== '';
4+
return getSketchVersion() !== 'NodeJS';
55
}

0 commit comments

Comments
Β (0)