Pluginfy RuboCop Airbnb (#212)

This PR adds support for RuboCop's Plugin feature.

It replaces the ad-hoc `Inject` hack with the RuboCop plugin system introduced in RuboCop 1.72.

- rubocop/rubocop#13792
- https://docs.rubocop.org/rubocop/plugin_migration_guide.html

Accordingly, rubocop-airbnb has been updated to require specific versions of the following
RuboCop extension plugins it depends on

- rubocop-performance (`~> 1.24`)
- rubocop-rails (`~> 2.30`)
- rubocop-rspec (`~> 3.5`)

The most significant change is that rubocop-rspec has been updated from version 2 to version 3.
As a result, `RSpec/Capybara` and `RSpec/FactoryBot` have been extracted into the following extension gems:

- rubocop-capybara
- rubocop-factory_bot

This PR adds dependencies on both rubocop-capybara and rubocop-rspec extensions to maintain
the previous rubocop-rspec configuration.

`RSpec/FilePath` has been split into `RSpec/SpecFilePathFormat` and `RSpec/SpecFilePathSuffix`,
so the original disabling has been retained in the configuration.
Similarly, `RSpec/Capybara/FeatureMethods` remains disabled as `RSpec/Dialect`.
https://github.com/rubocop/rubocop-rspec/blob/v3.5.0/config/obsoletion.yml

Resolves rubocop/rubocop-factory_bot#147.

Author: koic

rubocop-airbnb/.rubocop.yml

@@ -1,6 +1,8 @@
 inherit_from:
   - .rubocop_airbnb.yml
-  - ./config/default.yml
+
+plugins:
+  - rubocop-airbnb
 
 AllCops:
   CacheRootDirectory: tmp/rubocop

rubocop-airbnb/README.md

@@ -29,7 +29,7 @@ ways to do this:
 First Create a new file `.rubocop_airbnb.yml` in the same directory as your `.rubocop.yml`
 this file should contain
 ```
-require:
+plugins:
   - rubocop-airbnb
 ```
 
@@ -50,10 +50,13 @@ you could potentially experience a bunch of warnings from `.rubocop_todo.yml` fo
 Now you can run `rubocop` and it will automatically load the RuboCop Airbnb
 cops together with the standard cops.
 
+> [!NOTE]
+> The plugin system is supported in RuboCop 1.72+. In earlier versions, use `require` instead of `plugins`.
+
 ### Command line
 
 ```bash
-rubocop --require rubocop-airbnb
+rubocop --plugin rubocop-airbnb
 ```
 
 ## The Cops
@@ -70,4 +73,3 @@ Airbnb/PhraseBundleKeys:
   Exclude:
     - spec/my_poorly_named_spec_file.rb
 ```
-

rubocop-airbnb/config/default.yml

@@ -29,14 +29,16 @@ RSpec:
   Include:
   - _spec.rb
   - "(?:^|/)spec/"
-RSpec/FactoryBot:
+FactoryBot:
   Include:
   - spec/factories/**/*.rb
   - features/support/factories/**/*.rb
 
 inherit_from:
   - './rubocop-airbnb.yml'
   - './rubocop-bundler.yml'
+  - './rubocop-capybara.yml'
+  - './rubocop-factory_bot.yml'
   - './rubocop-gemspec.yml'
   - './rubocop-layout.yml'
   - './rubocop-lint.yml'

rubocop-airbnb/config/rubocop-capybara.yml

@@ -0,0 +1,6 @@
+plugins:
+  - rubocop-capybara
+
+Capybara/CurrentPathExpectation:
+  Description: Checks that no expectations are set on Capybara's `current_path`.
+  Enabled: false

rubocop-airbnb/config/rubocop-factory_bot.yml

@@ -0,0 +1,10 @@
+plugins:
+  - rubocop-factory_bot
+
+FactoryBot/AttributeDefinedStatically:
+  Description: Always declare attribute values as blocks.
+  Enabled: false
+
+FactoryBot/CreateList:
+  Description: Checks for create_list usage.
+  Enabled: true

rubocop-airbnb/config/rubocop-performance.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
     - rubocop-performance
 
 Performance/Caller:
@@ -122,4 +122,3 @@ Performance/UnfreezeString:
 
 Performance/UriDefaultParser:
   Enabled: false
-

rubocop-airbnb/config/rubocop-rails.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-rails
 
 # before_action doesn't seem to exist, so this doesn't make sense.

rubocop-airbnb/config/rubocop-rspec.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-rspec
 
 RSpec/AlignLeftLetBrace:
@@ -53,6 +53,10 @@ RSpec/DescribedClass:
   Description: 'Use `described_class` for tested class / module'
   Enabled: false
 
+RSpec/Dialect:
+  Description: Enforces custom RSpec dialects.
+  Enabled: false
+
 RSpec/EmptyExampleGroup:
   Description: Checks if an example group does not include any tests.
   Enabled: true
@@ -110,13 +114,6 @@ RSpec/ExpectOutput:
   Description: Checks for opportunities to use `expect { ... }.to output`.
   Enabled: false
 
-RSpec/FilePath:
-  Description: 'Checks the file and folder naming of the spec file.'
-  Enabled: false
-  CustomTransform:
-    RuboCop: rubocop
-    RSpec: rspec
-
 RSpec/Focus:
   Description: Checks if examples are focused.
   Enabled: false
@@ -293,6 +290,17 @@ RSpec/SingleArgumentMessageChain:
   Description: Checks that chains of messages contain more than one element.
   Enabled: true
 
+RSpec/SpecFilePathFormat:
+  Description: Checks that spec file paths are consistent and well-formed.
+  Enabled: false
+  CustomTransform:
+    RuboCop: rubocop
+    RSpec: rspec
+
+RSpec/SpecFilePathSuffix:
+  Description: Checks that spec file paths suffix are consistent and well-formed.
+  Enabled: false
+
 RSpec/SubjectStub:
   Description: Checks for stubbed test subjects.
   Enabled: false
@@ -308,19 +316,3 @@ RSpec/VerifiedDoubles:
 RSpec/VoidExpect:
   Description: This cop checks void `expect()`.
   Enabled: false
-
-RSpec/Capybara/CurrentPathExpectation:
-  Description: Checks that no expectations are set on Capybara's `current_path`.
-  Enabled: false
-
-RSpec/Capybara/FeatureMethods:
-  Description: Checks for consistent method usage in feature specs.
-  Enabled: false
-
-RSpec/FactoryBot/AttributeDefinedStatically:
-  Description: Always declare attribute values as blocks.
-  Enabled: false
-
-RSpec/FactoryBot/CreateList:
-  Description: Checks for create_list usage.
-  Enabled: true

rubocop-airbnb/lib/rubocop-airbnb.rb

@@ -7,8 +7,6 @@
 require 'rubocop-performance'
 require 'rubocop-rails'
 
-require 'rubocop/airbnb'
-require 'rubocop/airbnb/inject'
-require 'rubocop/airbnb/version'
-
-RuboCop::Airbnb::Inject.defaults!
+require_relative 'rubocop/airbnb'
+require_relative 'rubocop/airbnb/plugin'
+require_relative 'rubocop/airbnb/version'