FIX : Rename a rule #128

Author: VincentD06

runtime/docker-compose.yml

@@ -8,6 +8,8 @@ services:
   mongo:
     image: "mongo:6.0"
     container_name: mongo
+    networks:
+      - eh-network
     # uncomment to expose mongodb on localhost:27017
     # ports:
     #   - 27017:27017
@@ -28,6 +30,11 @@ services:
       memlock:
         soft: -1
         hard: -1
+    ports:
+      - 9200:9200
+    networks:
+      - eh-network
+
 
   # Graylog: https://hub.docker.com/r/graylog/graylog/
   graylog:
@@ -58,4 +65,11 @@ services:
     healthcheck:
       test: curl --head --fail http://localhost:9000 || exit 1
       start_period: 60s
+    networks:
+      - eh-network
+
+networks:
+  eh-network:
+    name: eh-network
+    driver: bridge
 

src/main/java/com/airbus_cyber_security/graylog/wizard/alert/rest/AlertRuleResource.java

@@ -456,14 +456,14 @@ public Response update(@ApiParam(name = TITLE, required = true)
         String notificationIdentifier = previousAlert.getNotificationID();
         String userName = getCurrentUser().getName();
 
-        this.notificationService.updateNotification(title, notificationIdentifier);
+        this.notificationService.updateNotification(request.getTitle(), notificationIdentifier);
 
         AlertType previousAlertType = previousAlert.getAlertType();
         AlertPattern pattern = updateAlertPattern(previousAlert.pattern(), notificationIdentifier, request,
-                previousAlertType, title, userContext, userName);
+                previousAlertType, request.getTitle(), userContext, userName);
 
         AlertRule alertRule = AlertRule.create(
-                title,
+                request.getTitle(),
                 request.getConditionType(),
                 pattern,
                 previousAlert.getNotificationID(),

src/web/wizard/pages/UpdateAlertPage.jsx

@@ -56,7 +56,7 @@ const UpdateAlertPage = ({params}) => {
 
     const _update = (alert) => {
         // TODO simplify parameters here (only one necessary and the code in AlertRuleStore)
-        AlertRuleActions.update(alert.title, alert).then((response) => {
+        AlertRuleActions.update(params.alertRuleTitle, alert).then((response) => {
             if (response !== true) {
                 return;
             }

validation/tests_fast.py

@@ -528,3 +528,10 @@ def test_create_alert_with_disable_state_should_have_disabled_stream__issue138(s
 
         response = self._api.get_stream(create_response['stream']['id'])
         self.assertEqual(True, response.json()['disabled'])
+
+    def test_update_alert_rule_title_should_not_fail__issue128(self):
+        title = 'title_to_update'
+        rule = self._api.create_alert_rule_count(title, _PERIOD)
+        response = self._graylog.update_alert_rule(title, {**rule, 'title': 'updated_title'}).json()
+
+        self.assertEqual('updated_title', response['title'])