Skip to content

fix: ensure database context is set before schema creation in Snowflake#589

Closed
devin-ai-integration[bot] wants to merge 11 commits intomainfrom
devin/1738038285-fix-snowflake-schema-creation
Closed

fix: ensure database context is set before schema creation in Snowflake#589
devin-ai-integration[bot] wants to merge 11 commits intomainfrom
devin/1738038285-fix-snowflake-schema-creation

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Fixes Snowflake schema creation by ensuring database context is properly set.

This PR:

  1. Overrides _ensure_schema_exists in SnowflakeSqlProcessor to properly set database context
  2. Uses fully qualified schema names in CREATE SCHEMA statements
  3. Maintains existing error handling for schema existence

Link to Devin run: https://app.devin.ai/sessions/be3168a4b7974151b7cf9f082e47e893

devin-ai-integration bot and others added 2 commits January 28, 2025 03:25
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

Original prompt:

@Devin - PyAirbyte CI tests are failing in new PRs. Can you investigate. Looks like Snowflake account is missing a DB or has its default DB changed.

@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration bot and others added 9 commits January 28, 2025 04:29
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@aaronsteers
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant