fix: --insecure-cookies broke for v2 charts (#178)

git-phu · web-flow · commit 5c9e204945b0 · 2025-08-19T10:49:49.000-07:00
diff --git a/internal/helm/airbyte_values.go b/internal/helm/airbyte_values.go
@@ -168,7 +168,7 @@ func buildAirbyteValuesV2(ctx context.Context, opts ValuesOpts) (string, error)
 
 	if opts.InsecureCookies {
 		// Boolean is a string value in the v1 Helm chart.
-		vals = append(vals, `global.auth.cookieSecureSetting="false"`)
+		vals = append(vals, `global.auth.security.cookieSecureSetting="false"`)
 	}
 
 	fileVals, err := maps.FromYAMLFile(opts.ValuesFile)
diff --git a/internal/helm/airbyte_values_test.go b/internal/helm/airbyte_values_test.go
@@ -244,7 +244,8 @@ connectorBuilderServer:
     enabled: false
 global:
     auth:
-        cookieSecureSetting: '"false"'
+        security:
+            cookieSecureSetting: '"false"'
         enabled: true
     env_vars:
         AIRBYTE_INSTALLATION_ID: test-user

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ func buildAirbyteValuesV2(ctx context.Context, opts ValuesOpts) (string, error)`
`168`	`168`
`169`	`169`	`if opts.InsecureCookies {`
`170`	`170`	`// Boolean is a string value in the v1 Helm chart.`
`171`		- vals = append(vals, `global.auth.cookieSecureSetting="false"`)
	`171`	+ vals = append(vals, `global.auth.security.cookieSecureSetting="false"`)
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`fileVals, err := maps.FromYAMLFile(opts.ValuesFile)`