Commit db5c519
committed
fix: pass migrate and normalize flags to the CDK if set on the manifest (#15961)
## What
EDIT: Changing this PR to only set the normalize flag for now, since we want to hold off on the `migrate` flag until we are ready to ship this to all users
We need to provide the way to communicate the `Form-Based UI` <> `CDK` to be able to toggle the `normalization` and the `migration` for the given manifest.
After the `Form-Based UI` is released to the world and stable - these flags should be removed or set to True at the CDK level for the time being.
## How
## Airbyte-Webapp
- set the `__should_normalize` and `__should_migrate` flags by UI to the `manifest` level
## Connector Builder Server
- handle the additional flags set by UI to be at the `root` of the requestBody == `config`, to not to introduce `declarative_component_schema.yaml` changes and handle this only in platform.
- This code path handles the above: `oss/airbyte-connector-builder-server/src/main/java/io/airbyte/connector_builder/requester/AirbyteCdkRequesterImpl.java` > `adaptConfig` for `ResolveManifest`.
## Can this PR be safely reverted and rolled back?
- [X] YES 💚
- [ ] NO ❌1 parent e4226b8 commit db5c519
File tree
1 file changed
+35
-1
lines changed- airbyte-connector-builder-server/src/main/kotlin/io/airbyte/connectorbuilder/requester
1 file changed
+35
-1
lines changedLines changed: 35 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
235 | 238 | | |
236 | 239 | | |
237 | 240 | | |
| |||
244 | 247 | | |
245 | 248 | | |
246 | 249 | | |
247 | | - | |
| 250 | + | |
248 | 251 | | |
249 | 252 | | |
250 | 253 | | |
251 | 254 | | |
252 | 255 | | |
253 | 256 | | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
254 | 260 | | |
255 | 261 | | |
256 | 262 | | |
| |||
285 | 291 | | |
286 | 292 | | |
287 | 293 | | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
288 | 297 | | |
289 | 298 | | |
290 | 299 | | |
| |||
328 | 337 | | |
329 | 338 | | |
330 | 339 | | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
331 | 363 | | |
332 | 364 | | |
333 | 365 | | |
| |||
354 | 386 | | |
355 | 387 | | |
356 | 388 | | |
| 389 | + | |
| 390 | + | |
357 | 391 | | |
358 | 392 | | |
359 | 393 | | |
| |||
0 commit comments