fix(helm): make services conditional on component (#16860)

Author: perangel

charts/helm-tests/tests/v2/connector_builder_server_test.go

@@ -0,0 +1,32 @@
+package tests
+
+import (
+	"testing"
+
+	helmtests "github.com/airbytehq/airbyte-platform-internal/oss/charts/helm-tests"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestConnectorBuilderServerDisabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["connectorBuilderServer.enabled"] = "false"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify connector-builder-server resources are not created when disabled
+	helmtests.AssertNoResource(t, chartYaml.String(), "Deployment", "airbyte-connector-builder-server")
+	helmtests.AssertNoResource(t, chartYaml.String(), "Service", "airbyte-airbyte-connector-builder-server-svc")
+}
+
+func TestConnectorBuilderServerEnabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["connectorBuilderServer.enabled"] = "true"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify connector-builder-server resources are created when enabled
+	assert.NotNil(t, helmtests.GetDeployment(chartYaml.String(), "airbyte-connector-builder-server"))
+	assert.NotNil(t, helmtests.GetService(chartYaml.String(), "airbyte-airbyte-connector-builder-server-svc"))
+}

charts/helm-tests/tests/v2/connector_rollout_worker_test.go

@@ -0,0 +1,30 @@
+package tests
+
+import (
+	"testing"
+
+	helmtests "github.com/airbytehq/airbyte-platform-internal/oss/charts/helm-tests"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestConnectorRolloutWorkerDisabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["connectorRolloutWorker.enabled"] = "false"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify connector-rollout-worker resources are not created when disabled
+	helmtests.AssertNoResource(t, chartYaml.String(), "Deployment", "airbyte-connector-rollout-worker")
+}
+
+func TestConnectorRolloutWorkerEnabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["connectorRolloutWorker.enabled"] = "true"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify connector-rollout-worker resources are created when enabled
+	assert.NotNil(t, helmtests.GetDeployment(chartYaml.String(), "airbyte-connector-rollout-worker"))
+}

charts/helm-tests/tests/v2/cron_test.go

@@ -0,0 +1,30 @@
+package tests
+
+import (
+	"testing"
+
+	helmtests "github.com/airbytehq/airbyte-platform-internal/oss/charts/helm-tests"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestCronDisabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["cron.enabled"] = "false"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify cron resources are not created when disabled
+	helmtests.AssertNoResource(t, chartYaml.String(), "Deployment", "airbyte-cron")
+}
+
+func TestCronEnabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["cron.enabled"] = "true"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify cron resources are created when enabled
+	assert.NotNil(t, helmtests.GetDeployment(chartYaml.String(), "airbyte-cron"))
+}

charts/helm-tests/tests/v2/featureflag_server_test.go

@@ -0,0 +1,32 @@
+package tests
+
+import (
+	"testing"
+
+	helmtests "github.com/airbytehq/airbyte-platform-internal/oss/charts/helm-tests"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestFeatureflagServerDisabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["featureflagServer.enabled"] = "false"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify featureflag-server resources are not created when disabled
+	helmtests.AssertNoResource(t, chartYaml.String(), "Deployment", "airbyte-featureflag-server")
+	helmtests.AssertNoResource(t, chartYaml.String(), "Service", "airbyte-featureflag-server-svc")
+}
+
+func TestFeatureflagServerEnabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["featureflagServer.enabled"] = "true"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify featureflag-server resources are created when enabled
+	assert.NotNil(t, helmtests.GetDeployment(chartYaml.String(), "airbyte-featureflag-server"))
+	assert.NotNil(t, helmtests.GetService(chartYaml.String(), "airbyte-featureflag-server-svc"))
+}

charts/helm-tests/tests/v2/keycloak_test.go

@@ -0,0 +1,62 @@
+package tests
+
+import (
+	"testing"
+
+	helmtests "github.com/airbytehq/airbyte-platform-internal/oss/charts/helm-tests"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestKeycloakDisabledCommunityEdition(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["global.edition"] = "community"
+	opts.SetValues["keycloak.enabled"] = "false"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify keycloak resources are not created when disabled or community edition
+	helmtests.AssertNoResource(t, chartYaml.String(), "StatefulSet", "airbyte-keycloak")
+	helmtests.AssertNoResource(t, chartYaml.String(), "Service", "airbyte-airbyte-keycloak-svc")
+	helmtests.AssertNoResource(t, chartYaml.String(), "Service", "airbyte-airbyte-keycloak-headless-svc")
+}
+
+func TestKeycloakDisabledEnterpriseEdition(t *testing.T) {
+	opts := helmtests.BaseHelmOptionsForEnterprise()
+	opts.SetValues["keycloak.enabled"] = "false"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify keycloak resources are not created when disabled even with enterprise edition
+	helmtests.AssertNoResource(t, chartYaml.String(), "StatefulSet", "airbyte-keycloak")
+	helmtests.AssertNoResource(t, chartYaml.String(), "Service", "airbyte-airbyte-keycloak-svc")
+	helmtests.AssertNoResource(t, chartYaml.String(), "Service", "airbyte-airbyte-keycloak-headless-svc")
+}
+
+func TestKeycloakEnabledEnterpriseEdition(t *testing.T) {
+	opts := helmtests.BaseHelmOptionsForEnterprise()
+	opts.SetValues["keycloak.enabled"] = "true"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify keycloak resources are created when enabled and enterprise edition
+	assert.NotNil(t, helmtests.GetStatefulSet(chartYaml.String(), "airbyte-keycloak"))
+	assert.NotNil(t, helmtests.GetService(chartYaml.String(), "airbyte-airbyte-keycloak-svc"))
+	assert.NotNil(t, helmtests.GetService(chartYaml.String(), "airbyte-airbyte-keycloak-headless-svc"))
+}
+
+func TestKeycloakEnabledCommunityEdition(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["global.edition"] = "community"
+	opts.SetValues["keycloak.enabled"] = "true"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify keycloak resources are not created when community edition (even if enabled)
+	helmtests.AssertNoResource(t, chartYaml.String(), "StatefulSet", "airbyte-keycloak")
+	helmtests.AssertNoResource(t, chartYaml.String(), "Service", "airbyte-airbyte-keycloak-svc")
+	helmtests.AssertNoResource(t, chartYaml.String(), "Service", "airbyte-airbyte-keycloak-headless-svc")
+}

charts/helm-tests/tests/v2/metrics_test.go

@@ -0,0 +1,30 @@
+package tests
+
+import (
+	"testing"
+
+	helmtests "github.com/airbytehq/airbyte-platform-internal/oss/charts/helm-tests"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestMetricsDisabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["metrics.enabled"] = "false"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify metrics resources are not created when disabled
+	helmtests.AssertNoResource(t, chartYaml.String(), "Deployment", "airbyte-metrics")
+}
+
+func TestMetricsEnabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["metrics.enabled"] = "true"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify metrics resources are created when enabled
+	assert.NotNil(t, helmtests.GetDeployment(chartYaml.String(), "airbyte-metrics"))
+}

charts/helm-tests/tests/v2/server_test.go

@@ -0,0 +1,32 @@
+package tests
+
+import (
+	"testing"
+
+	helmtests "github.com/airbytehq/airbyte-platform-internal/oss/charts/helm-tests"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestServerDisabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["server.enabled"] = "false"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify server resources are not created when disabled
+	helmtests.AssertNoResource(t, chartYaml.String(), "Deployment", "airbyte-server")
+	helmtests.AssertNoResource(t, chartYaml.String(), "Service", "airbyte-airbyte-server-svc")
+}
+
+func TestServerEnabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["server.enabled"] = "true"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify server resources are created when enabled
+	assert.NotNil(t, helmtests.GetDeployment(chartYaml.String(), "airbyte-server"))
+	assert.NotNil(t, helmtests.GetService(chartYaml.String(), "airbyte-airbyte-server-svc"))
+}

charts/helm-tests/tests/v2/temporal_test.go

@@ -0,0 +1,33 @@
+package tests
+
+import (
+	"testing"
+
+	helmtests "github.com/airbytehq/airbyte-platform-internal/oss/charts/helm-tests"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestTemporalDisabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["temporal.enabled"] = "false"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify temporal resources are not created when disabled
+	helmtests.AssertNoResource(t, chartYaml.String(), "Deployment", "airbyte-temporal")
+	helmtests.AssertNoResource(t, chartYaml.String(), "Service", "airbyte-temporal")
+	helmtests.AssertNoResource(t, chartYaml.String(), "ConfigMap", "airbyte-temporal-config")
+}
+
+func TestTemporalEnabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["temporal.enabled"] = "true"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify temporal resources are created when enabled
+	assert.NotNil(t, helmtests.GetDeployment(chartYaml.String(), "airbyte-temporal"))
+	assert.NotNil(t, helmtests.GetService(chartYaml.String(), "airbyte-temporal"))
+}

charts/helm-tests/tests/v2/temporal_ui_test.go

@@ -0,0 +1,32 @@
+package tests
+
+import (
+	"testing"
+
+	helmtests "github.com/airbytehq/airbyte-platform-internal/oss/charts/helm-tests"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestTemporalUiDisabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["temporalUi.enabled"] = "false"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify temporal-ui resources are not created when disabled
+	helmtests.AssertNoResource(t, chartYaml.String(), "Deployment", "airbyte-temporal-ui")
+	helmtests.AssertNoResource(t, chartYaml.String(), "Service", "airbyte-airbyte-temporal-ui-svc")
+}
+
+func TestTemporalUiEnabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["temporalUi.enabled"] = "true"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify temporal-ui resources are created when enabled
+	assert.NotNil(t, helmtests.GetDeployment(chartYaml.String(), "airbyte-temporal-ui"))
+	assert.NotNil(t, helmtests.GetService(chartYaml.String(), "airbyte-airbyte-temporal-ui-svc"))
+}

charts/helm-tests/tests/v2/webapp_test.go

@@ -0,0 +1,32 @@
+package tests
+
+import (
+	"testing"
+
+	helmtests "github.com/airbytehq/airbyte-platform-internal/oss/charts/helm-tests"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestWebappDisabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["webapp.enabled"] = "false"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify webapp resources are not created when disabled
+	helmtests.AssertNoResource(t, chartYaml.String(), "Deployment", "airbyte-webapp")
+	helmtests.AssertNoResource(t, chartYaml.String(), "Service", "airbyte-airbyte-webapp-svc")
+}
+
+func TestWebappEnabled(t *testing.T) {
+	opts := helmtests.BaseHelmOptions()
+	opts.SetValues["webapp.enabled"] = "true"
+	
+	chartYaml, err := helmtests.RenderHelmChart(t, opts, chartPath, "airbyte", nil)
+	assert.NoError(t, err)
+	
+	// Verify webapp resources are created when enabled
+	assert.NotNil(t, helmtests.GetDeployment(chartYaml.String(), "airbyte-webapp"))
+	assert.NotNil(t, helmtests.GetService(chartYaml.String(), "airbyte-airbyte-webapp-svc"))
+}