Skip to content

Commit 027fa8f

Browse files
authored
Merge branch 'main' into devin/1744958125-bump-unstructured-to-latest
2 parents ac669e3 + b148ca5 commit 027fa8f

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.github/workflows/connector-tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@ jobs:
7575
# Chargebee is being flaky:
7676
# - connector: source-chargebee
7777
# cdk_extra: n/a
78-
# These two are behind in CDK updates and can't be used as tests until they are updated:
79-
# - connector: source-s3
80-
# cdk_extra: file-based
78+
# This one is behind in CDK updates and can't be used as tests until it is updated:
8179
# - connector: destination-pinecone
8280
# cdk_extra: vector-db-based
81+
- connector: source-google-drive
82+
cdk_extra: file-based
8383
- connector: destination-motherduck
8484
cdk_extra: sql
8585
# ZenDesk currently failing (as of 2024-12-02)

airbyte_cdk/sources/declarative/requesters/query_properties/property_chunking.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def get_request_property_chunks(
5555
# todo: Add ability to specify parameter delimiter representation and take into account in property_field_size
5656
property_field_size = (
5757
len(property_field)
58-
+ 1 # The +1 represents the extra character for the delimiter in between properties
58+
+ 3 # The +3 represents the extra characters for encoding the delimiter in between properties
5959
if self.property_limit_type == PropertyLimitType.characters
6060
else 1
6161
)

unit_tests/sources/declarative/requesters/query_properties/test_property_chunking.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,15 @@
4343
["kate", "laurie", "jaclyn"],
4444
None,
4545
PropertyLimitType.characters,
46-
15,
46+
20,
4747
[["kate", "laurie"], ["jaclyn"]],
4848
id="test_property_chunking_limit_characters",
4949
),
5050
pytest.param(
5151
["laurie", "jaclyn", "kaitlin"],
5252
None,
5353
PropertyLimitType.characters,
54-
12,
54+
17, # laurie%2Cjaclyn%2C == 18, so this will create separate chunks
5555
[["laurie"], ["jaclyn"], ["kaitlin"]],
5656
id="test_property_chunking_includes_extra_delimiter",
5757
),

0 commit comments

Comments
 (0)