Skip to content

Commit 073a71e

Browse files
author
Oleksandr Bazarnov
committed
updated after the review
1 parent 17d77e8 commit 073a71e

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

airbyte_cdk/sources/declarative/requesters/http_job_repository.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,8 @@ def _get_creation_response_interpolation_context(self, job: AsyncJob) -> Dict[st
283283
Returns:
284284
Dict[str, Any]: The interpolation context as a dictionary.
285285
"""
286+
# TODO: currently we support only JsonDecoder to decode the response to track the ids or the status
287+
# of the Jobs. We should consider to add the support of other decoders like XMLDecoder, in the future
286288
creation_response_context = dict(self._create_job_response_by_id[job.api_job_id()].json())
287289
if not "headers" in creation_response_context:
288290
creation_response_context["headers"] = self._create_job_response_by_id[
@@ -304,6 +306,8 @@ def _get_polling_response_interpolation_context(self, job: AsyncJob) -> Dict[str
304306
Returns:
305307
Dict[str, Any]: The interpolation context as a dictionary.
306308
"""
309+
# TODO: currently we support only JsonDecoder to decode the response to track the ids or the status
310+
# of the Jobs. We should consider to add the support of other decoders like XMLDecoder, in the future
307311
polling_response_context = dict(self._polling_job_response_by_id[job.api_job_id()].json())
308312
if not "headers" in polling_response_context:
309313
polling_response_context["headers"] = self._polling_job_response_by_id[

0 commit comments

Comments
 (0)