Skip to content

Commit 081a36a

Browse files
committed
more now() updates
1 parent 8c4b8b7 commit 081a36a

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

airbyte_cdk/sources/streams/call_rate.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ def try_acquire(self, request: Any, weight: int) -> None:
334334
self._update_current_window()
335335

336336
if self._calls_num + weight > self._call_limit:
337-
reset_in = self._next_reset_ts - datetime.datetime.now()
337+
reset_in = self._next_reset_ts - ab_datetime_now()
338338
error_message = (
339339
f"reached maximum number of allowed calls {self._call_limit} "
340340
f"per {self._offset} interval, next reset in {reset_in}."

airbyte_cdk/utils/datetime_helpers.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,8 +347,6 @@ def from_str(cls, dt_str: str) -> "AirbyteDateTime":
347347
def ab_datetime_now() -> AirbyteDateTime:
348348
"""Returns the current time as an AirbyteDateTime in UTC timezone.
349349
350-
Previously named: now()
351-
352350
Returns:
353351
AirbyteDateTime: Current UTC time.
354352

unit_tests/sources/declarative/interpolation/test_jinja.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
from airbyte_cdk import StreamSlice
1212
from airbyte_cdk.sources.declarative.interpolation.jinja import JinjaInterpolation
1313
from airbyte_cdk.utils import AirbyteTracedException
14+
from airbyte_cdk.utils.datetime_helpers import ab_datetime_now
1415

1516
interpolation = JinjaInterpolation()
1617

@@ -148,9 +149,9 @@ def test_negative_day_delta():
148149
delta_template = "{{ day_delta(-25) }}"
149150
val = interpolation.eval(delta_template, {})
150151

151-
assert val <= (
152-
datetime.datetime.now(datetime.timezone.utc) - datetime.timedelta(days=25)
153-
).strftime("%Y-%m-%dT%H:%M:%S.%f%z")
152+
assert val <= (ab_datetime_now() - datetime.timedelta(days=25)).strftime(
153+
"%Y-%m-%dT%H:%M:%S.%f%z"
154+
)
154155

155156

156157
@pytest.mark.parametrize(

unit_tests/sources/file_based/availability_strategy/test_default_file_based_availability_strategy.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,10 @@
1616
from airbyte_cdk.sources.file_based.file_types.file_type_parser import FileTypeParser
1717
from airbyte_cdk.sources.file_based.remote_file import RemoteFile
1818
from airbyte_cdk.sources.file_based.stream import AbstractFileBasedStream
19+
from airbyte_cdk.utils.datetime_helpers import ab_datetime_now
1920

2021
_FILE_WITH_UNKNOWN_EXTENSION = RemoteFile(
21-
uri="a.unknown_extension", last_modified=datetime.now(), file_type="csv"
22+
uri="a.unknown_extension", last_modified=ab_datetime_now(), file_type="csv"
2223
)
2324
_ANY_CONFIG = FileBasedStreamConfig(
2425
name="config.name",

0 commit comments

Comments
 (0)