Skip to content

Commit 0839137

Browse files
committed
apply suggestion: rename to 'raise_if_errors'
1 parent aefed0d commit 0839137

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

airbyte_cdk/test/standard_tests/docker_base.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ def test_docker_image_build_and_spec(
163163
connector_image,
164164
"spec",
165165
],
166-
check=True,
166+
raise_if_errors=True,
167167
)
168168

169169
@pytest.mark.skipif(
@@ -218,7 +218,7 @@ def test_docker_image_build_and_check(
218218
"--config",
219219
container_config_path,
220220
],
221-
check=True,
221+
raise_if_errors=True,
222222
)
223223

224224
@pytest.mark.skipif(
@@ -311,7 +311,7 @@ def test_docker_image_build_and_read(
311311
"--config",
312312
container_config_path,
313313
],
314-
check=True,
314+
raise_if_errors=True,
315315
)
316316

317317
catalog_message = discover_result.catalog # Get catalog message
@@ -367,5 +367,5 @@ def test_docker_image_build_and_read(
367367
"--catalog",
368368
container_catalog_path,
369369
],
370-
check=True,
370+
raise_if_errors=True,
371371
)

airbyte_cdk/utils/docker.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,7 @@ def run_docker_command(
448448
def run_docker_airbyte_command(
449449
cmd: list[str],
450450
*,
451-
check: bool = False,
451+
raise_if_errors: bool = False,
452452
) -> EntrypointOutput:
453453
"""Run an Airbyte command inside a Docker container.
454454
@@ -457,7 +457,7 @@ def run_docker_airbyte_command(
457457
458458
Args:
459459
cmd: The command to run as a list of strings.
460-
check: If True, raises an exception if the command fails. If False, the caller is
460+
raise_if_errors: If True, raises an exception if the command fails. If False, the caller is
461461
responsible for checking the for errors.
462462
463463
Returns:
@@ -483,7 +483,7 @@ def run_docker_airbyte_command(
483483
else None
484484
),
485485
)
486-
if check:
486+
if raise_if_errors:
487487
# If check is True, we raise an exception if there are errors.
488488
# This will do nothing if there are no errors.
489489
result_output.raise_if_errors()

0 commit comments

Comments
 (0)