Skip to content

Commit 0a53391

Browse files
committed
update unit tests for additional job tracker argument
1 parent ed6bac5 commit 0a53391

File tree

6 files changed

+14
-13
lines changed

6 files changed

+14
-13
lines changed

unit_tests/sources/declarative/async_job/test_integration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def streams(self, config: Mapping[str, Any]) -> List[Stream]:
8787
job_orchestrator_factory=lambda stream_slices: AsyncJobOrchestrator(
8888
MockAsyncJobRepository(),
8989
stream_slices,
90-
JobTracker(_NO_LIMIT),
90+
JobTracker(_NO_LIMIT, config={}),
9191
self._message_repository,
9292
),
9393
config={},

unit_tests/sources/declarative/async_job/test_job_orchestrator.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def test_given_one_job_still_running_when_create_and_get_completed_partitions_th
137137
def test_given_timeout_when_create_and_get_completed_partitions_then_free_budget_and_raise_exception(
138138
self, mock_sleep: MagicMock
139139
) -> None:
140-
job_tracker = JobTracker(1)
140+
job_tracker = JobTracker(1, config={})
141141
self._job_repository.start.return_value = self._job_for_a_slice
142142
self._job_repository.update_jobs_status.side_effect = _status_update_per_jobs(
143143
{self._job_for_a_slice: [AsyncJobStatus.TIMED_OUT]}
@@ -184,15 +184,15 @@ def test_when_fetch_records_then_yield_records_from_each_job(self) -> None:
184184
def _orchestrator(
185185
self, slices: List[StreamSlice], job_tracker: Optional[JobTracker] = None
186186
) -> AsyncJobOrchestrator:
187-
job_tracker = job_tracker if job_tracker else JobTracker(_NO_JOB_LIMIT)
187+
job_tracker = job_tracker if job_tracker else JobTracker(_NO_JOB_LIMIT, config={})
188188
return AsyncJobOrchestrator(
189189
self._job_repository, slices, job_tracker, self._message_repository
190190
)
191191

192192
def test_given_more_jobs_than_limit_when_create_and_get_completed_partitions_then_still_return_all_slices_and_free_job_budget(
193193
self,
194194
) -> None:
195-
job_tracker = JobTracker(1)
195+
job_tracker = JobTracker(1, config={})
196196
self._job_repository.start.side_effect = [
197197
self._job_for_a_slice,
198198
self._job_for_another_slice,
@@ -220,7 +220,7 @@ def test_given_exception_to_break_when_start_job_and_raise_this_exception_and_ab
220220
orchestrator = AsyncJobOrchestrator(
221221
self._job_repository,
222222
[_A_STREAM_SLICE, _ANOTHER_STREAM_SLICE],
223-
JobTracker(_NO_JOB_LIMIT),
223+
JobTracker(_NO_JOB_LIMIT, config={}),
224224
self._message_repository,
225225
exceptions_to_break_on=[ValueError],
226226
)
@@ -241,7 +241,7 @@ def test_given_traced_config_error_when_start_job_and_raise_this_exception_and_a
241241
"""
242242
Since this is a config error, we assume the other jobs will fail for the same reasons.
243243
"""
244-
job_tracker = JobTracker(1)
244+
job_tracker = JobTracker(1, config={})
245245
self._job_repository.start.side_effect = MessageRepresentationAirbyteTracedErrors(
246246
"Can't create job", failure_type=FailureType.config_error
247247
)
@@ -318,7 +318,7 @@ def test_given_jobs_failed_more_than_max_attempts_when_create_and_get_completed_
318318
def given_budget_already_taken_before_start_when_create_and_get_completed_partitions_then_wait_for_budget_to_be_freed(
319319
self,
320320
) -> None:
321-
job_tracker = JobTracker(1)
321+
job_tracker = JobTracker(1, config={})
322322
intent_to_free = job_tracker.try_to_get_intent()
323323

324324
def wait_and_free_intent(_job_tracker: JobTracker, _intent_to_free: str) -> None:
@@ -341,7 +341,7 @@ def wait_and_free_intent(_job_tracker: JobTracker, _intent_to_free: str) -> None
341341
def test_given_start_job_raise_when_create_and_get_completed_partitions_then_free_budget(
342342
self,
343343
) -> None:
344-
job_tracker = JobTracker(1)
344+
job_tracker = JobTracker(1, config={})
345345
self._job_repository.start.side_effect = ValueError("Can't create job")
346346

347347
orchestrator = AsyncJobOrchestrator(

unit_tests/sources/declarative/async_job/test_job_tracker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
class JobTrackerTest(TestCase):
1717
def setUp(self) -> None:
18-
self._tracker = JobTracker(_LIMIT)
18+
self._tracker = JobTracker(_LIMIT, config={})
1919

2020
def test_given_limit_reached_when_remove_job_then_can_get_intent_again(self) -> None:
2121
intents = self._reach_limit()

unit_tests/sources/declarative/interpolation/test_macros.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,13 @@ def test_macros_export(test_name, fn_name, found_in_macros):
7575
"2022-01-01T01:01:01Z",
7676
"%s",
7777
"%Y-%m-%dT%H:%M:%SZ",
78-
"1640998861",
78+
"1641027661",
7979
),
8080
(
8181
"2022-01-01T01:01:01Z",
8282
"%ms",
8383
"%Y-%m-%dT%H:%M:%SZ",
84-
"1640998861000000",
84+
"1641027661000000",
8585
),
8686
],
8787
ids=[

unit_tests/sources/declarative/partition_routers/test_async_job_partition_router.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def test_stream_slices_with_single_partition_router():
2626
job_orchestrator_factory=lambda stream_slices: AsyncJobOrchestrator(
2727
MockAsyncJobRepository(),
2828
stream_slices,
29-
JobTracker(_NO_LIMIT),
29+
JobTracker(_NO_LIMIT, config={}),
3030
NoopMessageRepository(),
3131
),
3232
config={},
@@ -58,7 +58,7 @@ def test_stream_slices_with_parent_slicer():
5858
job_orchestrator_factory=lambda stream_slices: AsyncJobOrchestrator(
5959
MockAsyncJobRepository(),
6060
stream_slices,
61-
JobTracker(_NO_LIMIT),
61+
JobTracker(_NO_LIMIT, config={}),
6262
NoopMessageRepository(),
6363
),
6464
config={},

unit_tests/sources/declarative/test_concurrent_declarative_source.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,7 @@
349349
"path": "{{stream_slice['url']}}",
350350
"http_method": "GET",
351351
},
352+
"max_concurrent_jobs": 1,
352353
},
353354
"incremental_sync": {"$ref": "#/definitions/incremental_cursor"},
354355
"schema_loader": {

0 commit comments

Comments
 (0)