Merge branch 'christo/manifest-server-errors' of https://github.com/airbytehq/airbyte-python-cdk into christo/manifest-server-errors

Author: ChristoGrab

airbyte_cdk/manifest_server/routers/manifest.py

@@ -8,14 +8,14 @@
 from fastapi.responses import JSONResponse
 
 from airbyte_cdk.models import AirbyteStateMessageSerializer
-from airbyte_cdk.utils.traced_exception import AirbyteTracedException
 from airbyte_cdk.sources.declarative.concurrent_declarative_source import (
     ConcurrentDeclarativeSource,
 )
 from airbyte_cdk.sources.declarative.parsers.custom_code_compiler import (
     INJECTED_COMPONENTS_PY,
     INJECTED_COMPONENTS_PY_CHECKSUMS,
 )
+from airbyte_cdk.utils.traced_exception import AirbyteTracedException
 
 from ..api_models import (
     CheckRequest,
@@ -161,7 +161,9 @@ def discover(request: DiscoverRequest) -> DiscoverResponse:
         runner = ManifestCommandProcessor(source)
         catalog = runner.discover(request.config.model_dump())
         if catalog is None:
-            raise HTTPException(status_code=422, detail="Connector did not return a discovered catalog")
+            raise HTTPException(
+                status_code=422, detail="Connector did not return a discovered catalog"
+            )
         return DiscoverResponse(catalog=catalog)
     except HTTPException:
         # Re-raise HTTPExceptions as-is (like the catalog None check above)

unit_tests/manifest_server/routers/test_manifest.py

@@ -538,14 +538,16 @@ def test_test_read_cdk_error_handling(
         request_data = {
             "manifest": sample_manifest,
             "config": sample_config,
-            "stream_name": "products"
+            "stream_name": "products",
         }
 
         mock_build_source.return_value = mock_source
 
         mock_runner = Mock()
         # Simulate a CDK error (like datetime parsing error)
-        mock_runner.test_read.side_effect = ValueError("time data '' does not match format '%Y-%m-%dT%H:%M:%SZ'")
+        mock_runner.test_read.side_effect = ValueError(
+            "time data '' does not match format '%Y-%m-%dT%H:%M:%SZ'"
+        )
         mock_runner_class.return_value = mock_runner
 
         response = client.post("/v1/manifest/test_read", json=request_data)
@@ -610,9 +612,7 @@ def test_discover_cdk_error_handling(
         assert "Schema validation failed" in data["detail"]
 
     @patch("airbyte_cdk.manifest_server.routers.manifest.build_source")
-    def test_resolve_cdk_error_handling(
-        self, mock_build_source, sample_manifest
-    ):
+    def test_resolve_cdk_error_handling(self, mock_build_source, sample_manifest):
         """Test that CDK errors in resolve are properly caught and converted to HTTP 400."""
         request_data = {
             "manifest": sample_manifest,
@@ -634,11 +634,7 @@ def test_full_resolve_cdk_error_handling(
         self, mock_build_source, sample_manifest, sample_config
     ):
         """Test that CDK errors in full_resolve are properly caught and converted to HTTP 400."""
-        request_data = {
-            "manifest": sample_manifest,
-            "config": sample_config,
-            "stream_limit": 10
-        }
+        request_data = {"manifest": sample_manifest, "config": sample_config, "stream_limit": 10}
 
         # Simulate a CDK error during source building
         mock_build_source.side_effect = KeyError("Missing required field 'streams'")