Skip to content

Commit 0c3efaf

Browse files
committed
fix mypy errors and a failing test
1 parent 09cb8b8 commit 0c3efaf

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

airbyte_cdk/sources/declarative/declarative_component_schema.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1484,6 +1484,9 @@ definitions:
14841484
examples:
14851485
- "{{ record.id }}/{{ record.file_name }}/"
14861486
- "{{ record.id }}_{{ record.file_name }}/"
1487+
$parameters:
1488+
type: object
1489+
additional_properties: true
14871490
$parameters:
14881491
type: object
14891492
additional_properties: true

airbyte_cdk/sources/declarative/models/declarative_component_schema.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2085,6 +2085,7 @@ class FileUploader(BaseModel):
20852085
"{{ record.id }}_{{ record.file_name }}/",
20862086
],
20872087
)
2088+
parameters: Optional[Dict[str, Any]] = Field(None, alias="$parameters")
20882089

20892090

20902091
class DeclarativeStream(BaseModel):

airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2967,7 +2967,10 @@ def create_simple_retriever(
29672967
model.requester.request_parameters = self._remove_query_properties(
29682968
model.requester.request_parameters
29692969
)
2970-
elif model.requester.fetch_properties_from_endpoint:
2970+
elif (
2971+
hasattr(model.requester, "fetch_properties_from_endpoint")
2972+
and model.requester.fetch_properties_from_endpoint
2973+
):
29712974
query_properties_definition = QueryPropertiesModel(
29722975
type="QueryProperties",
29732976
property_list=model.requester.fetch_properties_from_endpoint,

0 commit comments

Comments
 (0)