Skip to content

Commit 1d72e7c

Browse files
fix: address PR comments and dependency issues
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
1 parent e0d6b1b commit 1d72e7c

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,5 @@ dist
1515
.idea
1616
.vscode
1717
**/__pycache__
18-
unit_tests/resources/sample_connector/secrets/config.json
18+
**/.secrets/
19+
**/secrets/

airbyte_cdk/test/README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,13 @@ The CDK includes a pytest plugin that automatically discovers connectors and the
1111
1. Install the Airbyte CDK with test extras:
1212

1313
```bash
14-
pip install airbyte-cdk[tests]
14+
poetry add airbyte-cdk[tests]
15+
```
16+
17+
Or if you're developing the CDK itself:
18+
19+
```bash
20+
poetry install --extras tests
1521
```
1622

1723
2. Run pytest in your connector directory with auto-discovery enabled:

pyproject.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@ tests = ["pytest", "pytest-mock", "pytest-cov"]
117117
source-declarative-manifest = "airbyte_cdk.cli.source_declarative_manifest:run"
118118

119119
[tool.poetry.plugins.pytest11]
120+
# pytest11 is the entry point group name for pytest plugins
121+
# https://docs.pytest.org/en/7.3.x/how-to/writing_plugins.html#making-your-plugin-installable-by-others
120122
airbyte_cdk = "airbyte_cdk.test.pytest_config.plugin"
121123

122124
[tool.isort]
@@ -256,4 +258,5 @@ DEP004 = [
256258
# TODO: These should probably be declared within a `tests` extra:
257259
"pytest",
258260
"requests_mock",
261+
"_pytest",
259262
]

0 commit comments

Comments
 (0)