Skip to content

Commit 2812e7d

Browse files
committed
tidy up pr
1 parent 1468a48 commit 2812e7d

File tree

5 files changed

+5
-8
lines changed

5 files changed

+5
-8
lines changed

airbyte_cdk/test/declarative/test_suites/connector_base.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,12 @@
88
import sys
99
from collections.abc import Callable
1010
from pathlib import Path
11-
from typing import Any, Literal, cast
11+
from typing import cast
1212

1313
import pytest
1414
import yaml
1515
from boltons.typeutils import classproperty
1616

17-
from airbyte_cdk import Connector
1817
from airbyte_cdk.models import (
1918
AirbyteMessage,
2019
Type,

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ check-lockfile = {cmd = "poetry check", help = "Check the poetry lock file."}
153153
lint-fix = { cmd = "poetry run ruff check --fix .", help = "Auto-fix any lint issues that Ruff can automatically resolve (excluding 'unsafe' fixes)." }
154154
lint-fix-unsafe = { cmd = "poetry run ruff check --fix --unsafe-fixes .", help = "Lint-fix modified files, including 'unsafe' fixes. It is recommended to first commit any pending changes and then always manually review any unsafe changes applied." }
155155

156-
# ruff fix everything
156+
# ruff fix everything (ignoring non-Python fixes)
157157
ruff-fix = { sequence = ["lint-fix", "_format-fix-ruff"] , help = "Lint-fix and format-fix all code." }
158158

159159
# Combined Check and Fix tasks

unit_tests/resources/source_pokeapi_w_components_py/integration_tests/test_mini_cat.py renamed to unit_tests/resources/source_pokeapi_w_components_py/integration_tests/test_airbyte_standards.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Copyright (c) 2025 Airbyte, Inc., all rights reserved.
2-
from pathlib import Path
2+
"""FAST Airbyte Standard Tests for the source_pokeapi_w_components source."""
33

44
from airbyte_cdk.test.declarative.test_suites import (
55
DeclarativeSourceTestSuite,

unit_tests/source_declarative_manifest/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
# Copyright (c) 2024 Airbyte, Inc., all rights reserved.
33
#
44

5-
import os
65
from pathlib import Path
76

87
import pytest

unit_tests/source_declarative_manifest/test_source_declarative_w_custom_components.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ def get_py_components_config_dict(
9696
"components.py" if not failing_components else "components_failing.py"
9797
)
9898
config_yaml_path: Path = connector_dir / "valid_config.yaml"
99-
# secrets_yaml_path: Path = connector_dir / "secrets.yaml"
10099

101100
manifest_dict = yaml.safe_load(manifest_yaml_path.read_text())
102101
assert manifest_dict, "Failed to load the manifest file."
@@ -266,8 +265,8 @@ def test_sync_with_injected_py_components(
266265
streams=[
267266
ConfiguredAirbyteStream(
268267
stream=stream,
269-
sync_mode="full_refresh",
270-
destination_sync_mode="overwrite",
268+
sync_mode="full_refresh", # type: ignore (intentional bad value)
269+
destination_sync_mode="overwrite", # type: ignore (intentional bad value)
271270
)
272271
for stream in catalog.streams
273272
]

0 commit comments

Comments
 (0)