fix lint and typing

Author: aaronsteers

airbyte_cdk/test/declarative/test_suites/__init__.py

@@ -6,6 +6,7 @@
 
 from airbyte_cdk.test.declarative.test_suites.connector_base import (
     ConnectorTestScenario,
+    ConnectorTestSuiteBase,
     generate_tests,
 )
 from airbyte_cdk.test.declarative.test_suites.declarative_sources import (

airbyte_cdk/test/declarative/test_suites/declarative_sources.py

@@ -12,6 +12,7 @@
 from airbyte_cdk.test.declarative.test_suites.source_base import (
     SourceTestSuiteBase,
 )
+from airbyte_cdk.test.declarative.utils.job_runner import IConnector
 
 
 def md5_checksum(file_path: Path) -> str:
@@ -23,26 +24,31 @@ class DeclarativeSourceTestSuite(SourceTestSuiteBase):
     manifest_path = Path("manifest.yaml")
     components_py_path: Path | None = None
 
+    @classmethod
     def create_connector(
-        self, connector_test: ConnectorTestScenario
-    ) -> ConcurrentDeclarativeSource:
+        cls,
+        scenario: ConnectorTestScenario,
+    ) -> IConnector:
         """Create a connector instance for the test suite."""
-        config = connector_test.get_config_dict()
-        # catalog = connector_test.get_catalog()
-        # state = connector_test.get_state()
-        # source_config = connector_test.get_source_config()
+        config: dict[str, Any] = scenario.get_config_dict()
+        # catalog = scenario.get_catalog()
+        # state = scenario.get_state()
+        # source_config = scenario.get_source_config()
 
-        manifest_dict = yaml.safe_load(self.manifest_path.read_text())
-        if self.components_py_path and self.components_py_path.exists():
+        manifest_dict = yaml.safe_load(cls.manifest_path.read_text())
+        if cls.components_py_path and cls.components_py_path.exists():
             os.environ["AIRBYTE_ENABLE_UNSAFE_CODE"] = "true"
-            config["__injected_components_py"] = self.components_py_path.read_text()
+            config["__injected_components_py"] = cls.components_py_path.read_text()
             config["__injected_components_py_checksums"] = {
-                "md5": md5_checksum(self.components_py_path),
+                "md5": md5_checksum(cls.components_py_path),
             }
 
-        return ConcurrentDeclarativeSource(
-            config=config,
-            catalog=None,
-            state=None,
-            source_config=manifest_dict,
+        return cast(
+            IConnector,
+            ConcurrentDeclarativeSource(
+                config=config,
+                catalog=None,
+                state=None,
+                source_config=manifest_dict,
+            ),
         )

airbyte_cdk/test/declarative/test_suites/source_base.py

@@ -2,9 +2,6 @@
 """Base class for source test suites."""
 
 from dataclasses import asdict
-from pathlib import Path
-
-import pytest
 
 from airbyte_cdk.models import (
     AirbyteMessage,

pyproject.toml

@@ -32,6 +32,7 @@ enable = true
 python = ">=3.10,<3.13"
 airbyte-protocol-models-dataclasses = "^0.14"
 backoff = "*"
+boltons = "^25.0.0"
 cachetools = "*"
 dpath = "^2.1.6"
 dunamai = "^1.22.0"
@@ -83,7 +84,6 @@ sqlalchemy = {version = "^2.0,!=2.0.36", optional = true }
 xmltodict = ">=0.13,<0.15"
 anyascii = "^0.3.2"
 whenever = "^0.6.16"
-boltons = "^25.0.0"
 
 [tool.poetry.group.dev.dependencies]
 freezegun = "*"

unit_tests/resources/source_pokeapi_w_components_py/integration_tests/test_mini_cat.py

@@ -30,4 +30,3 @@ class TestSuiteSourcePokeAPI(DeclarativeSourceTestSuite):
     working_dir = CONNECTOR_ROOT
     manifest_path = get_resource_path("manifest.yaml")
     components_py_path = get_resource_path("components.py")
-    acceptance_test_config_path = get_resource_path("acceptance-test-config.yml")