Skip to content

Commit 5a1d1d9

Browse files
committed
pass in stream_name conditionally to remove unnecessary parameter
1 parent 7b04421 commit 5a1d1d9

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

airbyte_cdk/sources/declarative/manifest_declarative_source.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ def _dynamic_stream_configs(
546546
COMPONENTS_RESOLVER_TYPE_MAPPING[resolver_type],
547547
components_resolver_config,
548548
config,
549-
stream_name=dynamic_definition.get("name"),
549+
**({"stream_name": dynamic_definition.get("name")} if resolver_type == "HttpComponentsResolver" else {}),
550550
)
551551

552552
stream_template_config = dynamic_definition["stream_template"]

airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3859,7 +3859,6 @@ def create_config_components_resolver(
38593859
self,
38603860
model: ConfigComponentsResolverModel,
38613861
config: Config,
3862-
stream_name: Optional[str] = None,
38633862
) -> Any:
38643863
model_stream_configs = (
38653864
model.stream_config if isinstance(model.stream_config, list) else [model.stream_config]
@@ -3895,7 +3894,6 @@ def create_parametrized_components_resolver(
38953894
self,
38963895
model: ParametrizedComponentsResolverModel,
38973896
config: Config,
3898-
stream_name: Optional[str] = None,
38993897
) -> ParametrizedComponentsResolver:
39003898
stream_parameters = StreamParametersDefinition(
39013899
list_of_parameters_for_stream=model.stream_parameters.list_of_parameters_for_stream

0 commit comments

Comments
 (0)