style: apply ruff formatting to qa module

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

Author: devin-ai-integration[bot]

airbyte_cdk/qa/__init__.py

@@ -59,7 +59,7 @@ class MyCustomCheck(Check):
     name = "My custom check"
     description = "Description of what my check verifies"
     category = CheckCategory.TESTING
-    
+
     def _run(self, connector: Connector) -> CheckResult:
         if some_condition:
             return self.pass_(connector, "Check passed message")

airbyte_cdk/qa/checks/documentation/documentation.py

@@ -16,7 +16,9 @@ class CheckDocumentationExists(DocumentationCheck):
     """Check that connectors have documentation."""
 
     name = "Connectors must have documentation"
-    description = "Connectors must have documentation to ensure that users can understand how to use them."
+    description = (
+        "Connectors must have documentation to ensure that users can understand how to use them."
+    )
 
     def _run(self, connector: Connector) -> CheckResult:
         """Run the check.
@@ -29,9 +31,11 @@ def _run(self, connector: Connector) -> CheckResult:
         """
         docs_dir = Path("/home/ubuntu/repos/airbyte/docs/integrations")
         connector_type_dir = docs_dir / (connector.connector_type + "s")
-        
-        doc_file = connector_type_dir / (connector.technical_name.replace("source-", "").replace("destination-", "") + ".md")
-        
+
+        doc_file = connector_type_dir / (
+            connector.technical_name.replace("source-", "").replace("destination-", "") + ".md"
+        )
+
         if not doc_file.exists():
             return self.create_check_result(
                 connector=connector,

airbyte_cdk/qa/checks/metadata.py

@@ -33,15 +33,19 @@ def _run(self, connector: Connector) -> CheckResult:
             CheckResult: The result of the check
         """
         if not connector.metadata_file_path.exists():
-            return self.fail(connector=connector, message=f"Metadata file {consts.METADATA_FILE_NAME} does not exist")
-        
+            return self.fail(
+                connector=connector,
+                message=f"Metadata file {consts.METADATA_FILE_NAME} does not exist",
+            )
+
         try:
             with open(connector.metadata_file_path, "r") as f:
                 yaml.safe_load(f)
         except yaml.YAMLError as e:
-            return self.fail(connector=connector, message=f"Metadata file is invalid YAML: {str(e)}")
-        
-        
+            return self.fail(
+                connector=connector, message=f"Metadata file is invalid YAML: {str(e)}"
+            )
+
         return self.pass_(
             connector=connector,
             message="Metadata file exists and is valid YAML.",
@@ -100,7 +104,11 @@ def _run(self, connector: Connector) -> CheckResult:
                 message="Could not infer the language tag from the connector directory",
             )
 
-        current_language_tags = [t for t in (connector.metadata.get("tags", []) if connector.metadata else []) if t.startswith("language:")]
+        current_language_tags = [
+            t
+            for t in (connector.metadata.get("tags", []) if connector.metadata else [])
+            if t.startswith("language:")
+        ]
         if not current_language_tags:
             return self.fail(
                 connector=connector,
@@ -146,15 +154,21 @@ def get_expected_cdk_tag(self, connector: Connector) -> str:
         Returns:
             str: The expected CDK tag
         """
-        manifest_file = connector.code_directory / connector.technical_name.replace("-", "_") / "manifest.yaml"
+        manifest_file = (
+            connector.code_directory / connector.technical_name.replace("-", "_") / "manifest.yaml"
+        )
         pyproject_file = connector.code_directory / consts.PYPROJECT_FILE_NAME
         setup_py_file = connector.code_directory / "setup.py"
         if manifest_file.exists():
             return self.CDKTag.LOW_CODE
         if pyproject_file.exists():
             pyproject = toml.load((connector.code_directory / consts.PYPROJECT_FILE_NAME))
             cdk_deps = pyproject["tool"]["poetry"]["dependencies"].get("airbyte-cdk", None)
-            if cdk_deps and isinstance(cdk_deps, dict) and "file-based" in cdk_deps.get("extras", []):
+            if (
+                cdk_deps
+                and isinstance(cdk_deps, dict)
+                and "file-based" in cdk_deps.get("extras", [])
+            ):
                 return self.CDKTag.FILE
         if setup_py_file.exists():
             if "airbyte-cdk[file-based]" in (connector.code_directory / "setup.py").read_text():
@@ -170,7 +184,11 @@ def _run(self, connector: Connector) -> CheckResult:
         Returns:
             CheckResult: The result of the check
         """
-        current_cdk_tags = [t for t in (connector.metadata.get("tags", []) if connector.metadata else []) if t.startswith("cdk:")]
+        current_cdk_tags = [
+            t
+            for t in (connector.metadata.get("tags", []) if connector.metadata else [])
+            if t.startswith("cdk:")
+        ]
         expected_cdk_tag = self.get_expected_cdk_tag(connector)
         if not current_cdk_tags:
             return self.fail(
@@ -217,7 +235,9 @@ def _run(self, connector: Connector) -> CheckResult:
                 message="Can't verify breaking changes deadline: connector version is not defined.",
             )
 
-        breaking_changes = (connector.metadata.get("releases", {}) if connector.metadata else {}).get("breakingChanges")
+        breaking_changes = (
+            connector.metadata.get("releases", {}) if connector.metadata else {}
+        ).get("breakingChanges")
 
         if not breaking_changes:
             return self.pass_(
@@ -250,7 +270,10 @@ def _run(self, connector: Connector) -> CheckResult:
                 message=f"The upgrade deadline for the breaking changes in {current_version} is less than {self.minimum_days_until_deadline} days from today. Please extend the deadline",
             )
 
-        return self.pass_(connector=connector, message="The upgrade deadline is set to at least a week in the future")
+        return self.pass_(
+            connector=connector,
+            message="The upgrade deadline is set to at least a week in the future",
+        )
 
 
 class CheckConnectorMaxSecondsBetweenMessagesValue(MetadataCheck):
@@ -270,7 +293,9 @@ def _run(self, connector: Connector) -> CheckResult:
         Returns:
             CheckResult: The result of the check
         """
-        max_seconds_between_messages = connector.metadata.get("maxSecondsBetweenMessages") if connector.metadata else None
+        max_seconds_between_messages = (
+            connector.metadata.get("maxSecondsBetweenMessages") if connector.metadata else None
+        )
         if not max_seconds_between_messages:
             return self.fail(
                 connector=connector,

airbyte_cdk/qa/checks/packaging.py

@@ -43,7 +43,9 @@ def _run(self, connector: Connector) -> CheckResult:
                 message=f"{consts.PYPROJECT_FILE_NAME} file is missing",
             )
         if not (connector.code_directory / consts.POETRY_LOCK_FILE_NAME).exists():
-            return self.fail(connector=connector, message=f"{consts.POETRY_LOCK_FILE_NAME} file is missing")
+            return self.fail(
+                connector=connector, message=f"{consts.POETRY_LOCK_FILE_NAME} file is missing"
+            )
         if (connector.code_directory / "setup.py").exists():
             return self.fail(
                 connector=connector,
@@ -82,7 +84,9 @@ def _run(self, connector: Connector) -> CheckResult:
                 passed=False,
                 message=f"PyPi publishing is not declared. Please set it in the {consts.METADATA_FILE_NAME} file",
             )
-        return self.create_check_result(connector=connector, passed=True, message="PyPi publishing is declared")
+        return self.create_check_result(
+            connector=connector, passed=True, message="PyPi publishing is declared"
+        )
 
 
 class CheckManifestOnlyConnectorBaseImage(PackagingCheck):
@@ -110,7 +114,11 @@ def _run(self, connector: Connector) -> CheckResult:
                 passed=False,
                 message=f"A manifest-only connector must use `source-declarative-manifest` base image. Replace the base image in {consts.METADATA_FILE_NAME} file",
             )
-        return self.create_check_result(connector=connector, passed=True, message="Connector uses source-declarative-manifest base image")
+        return self.create_check_result(
+            connector=connector,
+            passed=True,
+            message="Connector uses source-declarative-manifest base image",
+        )
 
 
 class CheckConnectorLicense(PackagingCheck):
@@ -323,7 +331,7 @@ def _run(self, connector: Connector) -> CheckResult:
                 passed=False,
                 message=f"dockerImageTag is missing in {consts.METADATA_FILE_NAME}",
             )
-        
+
         try:
             semver.Version.parse(str(connector.metadata["dockerImageTag"]))
         except ValueError:
@@ -332,7 +340,7 @@ def _run(self, connector: Connector) -> CheckResult:
                 passed=False,
                 message=f"Connector version {connector.metadata['dockerImageTag']} does not follow semantic versioning",
             )
-        
+
         return self.create_check_result(
             connector=connector,
             passed=True,

airbyte_cdk/qa/checks/security.py

@@ -71,11 +71,20 @@ def _read_all_files_in_directory(
             Tuple[Path, str]: The file path and line content
         """
         ignored_directories = ignored_directories if ignored_directories is not None else set()
-        ignored_filename_patterns = ignored_filename_patterns if ignored_filename_patterns is not None else set()
+        ignored_filename_patterns = (
+            ignored_filename_patterns if ignored_filename_patterns is not None else set()
+        )
 
         for path in directory.rglob("*"):
-            ignore_directory = any([ignored_directory in path.parts for ignored_directory in ignored_directories])
-            ignore_filename = any([path.match(ignored_filename_pattern) for ignored_filename_pattern in ignored_filename_patterns])
+            ignore_directory = any(
+                [ignored_directory in path.parts for ignored_directory in ignored_directories]
+            )
+            ignore_filename = any(
+                [
+                    path.match(ignored_filename_pattern)
+                    for ignored_filename_pattern in ignored_filename_patterns
+                ]
+            )
             ignore = ignore_directory or ignore_filename
             if path.is_file() and not ignore:
                 try:
@@ -148,9 +157,7 @@ def _run(self, connector: Connector) -> CheckResult:
 class CheckConnectorUsesPythonBaseImage(SecurityCheck):
     """Check that Python connectors use the Python connector base image."""
 
-    name = (
-        f"Python connectors must not use a Dockerfile and must declare their base image in {consts.METADATA_FILE_NAME} file"
-    )
+    name = f"Python connectors must not use a Dockerfile and must declare their base image in {consts.METADATA_FILE_NAME} file"
     description = f"Connectors must use our Python connector base image, declared through the `connectorBuildOptions.baseImage` in their `{consts.METADATA_FILE_NAME}`.\nThis is to ensure that all connectors use a base image which is maintained and has security updates."
     applies_to_connector_languages = [
         ConnectorLanguage.PYTHON,
@@ -175,7 +182,9 @@ def _run(self, connector: Connector) -> CheckResult:
                 message=f"Dockerfile file exists. Please remove it and declare the base image in {consts.METADATA_FILE_NAME} file with the `connectorBuildOptions.baseImage` key",
             )
 
-        base_image = (connector.metadata.get("connectorBuildOptions", {}) if connector.metadata else {}).get("baseImage")
+        base_image = (
+            connector.metadata.get("connectorBuildOptions", {}) if connector.metadata else {}
+        ).get("baseImage")
         if not base_image:
             return self.create_check_result(
                 connector=connector,

airbyte_cdk/qa/checks/testing.py

@@ -14,7 +14,9 @@ class CheckConnectorHasAcceptanceTests(TestingCheck):
     """Check that connectors have acceptance tests."""
 
     name = "Connectors must have acceptance tests"
-    description = "Connectors must have acceptance tests to ensure that they meet the Airbyte specification."
+    description = (
+        "Connectors must have acceptance tests to ensure that they meet the Airbyte specification."
+    )
 
     def _run(self, connector: Connector) -> CheckResult:
         """Run the check.

airbyte_cdk/qa/connector.py

@@ -98,15 +98,15 @@ def code_directory(self) -> Path:
         """
         if self._connector_directory:
             return self._connector_directory
-        
+
         cwd = Path.cwd()
         if cwd.name == self.technical_name:
             return cwd
-        
+
         for parent in cwd.parents:
             if parent.name == self.technical_name:
                 return parent
-        
+
         return cwd
 
     @property
@@ -142,9 +142,15 @@ def language(self) -> Optional[ConnectorLanguage]:
         Returns:
             ConnectorLanguage: The programming language of the connector
         """
-        if Path(self.code_directory / "setup.py").exists() or Path(self.code_directory / "pyproject.toml").exists():
+        if (
+            Path(self.code_directory / "setup.py").exists()
+            or Path(self.code_directory / "pyproject.toml").exists()
+        ):
             return ConnectorLanguage.PYTHON
-        if Path(self.code_directory / "src" / "main" / "java").exists() or Path(self.code_directory / "src" / "main" / "kotlin").exists():
+        if (
+            Path(self.code_directory / "src" / "main" / "java").exists()
+            or Path(self.code_directory / "src" / "main" / "kotlin").exists()
+        ):
             return ConnectorLanguage.JAVA
         if self.manifest_path.exists():
             return ConnectorLanguage.LOW_CODE
@@ -247,7 +253,7 @@ def is_released(self) -> bool:
         """
         if self._is_released is not None:
             return self._is_released
-        
+
         self._is_released = True
         return True
 

airbyte_cdk/qa/models.py

@@ -1,4 +1,3 @@
-
 from __future__ import annotations
 
 import json
@@ -196,12 +195,18 @@ def run(self, connector: Connector) -> CheckResult:
                 connector,
                 f"Check does not apply to {connector.connector_type} connectors",
             )
-        if self.applies_to_connector_support_levels and connector.support_level not in self.applies_to_connector_support_levels:
+        if (
+            self.applies_to_connector_support_levels
+            and connector.support_level not in self.applies_to_connector_support_levels
+        ):
             return self.skip(
                 connector,
                 f"Check does not apply to {connector.support_level} connectors",
             )
-        if self.applies_to_connector_cloud_usage and connector.cloud_usage not in self.applies_to_connector_cloud_usage:
+        if (
+            self.applies_to_connector_cloud_usage
+            and connector.cloud_usage not in self.applies_to_connector_cloud_usage
+        ):
             return self.skip(
                 connector,
                 f"Check does not apply to {connector.cloud_usage} connectors",
@@ -239,7 +244,9 @@ def pass_(self, connector: Connector, message: str) -> CheckResult:
         Returns:
             CheckResult: A passing check result
         """
-        return CheckResult(connector=connector, check=self, status=CheckStatus.PASSED, message=message)
+        return CheckResult(
+            connector=connector, check=self, status=CheckStatus.PASSED, message=message
+        )
 
     def fail(self, connector: Connector, message: str) -> CheckResult:
         """Create a failing check result.
@@ -251,7 +258,9 @@ def fail(self, connector: Connector, message: str) -> CheckResult:
         Returns:
             CheckResult: A failing check result
         """
-        return CheckResult(connector=connector, check=self, status=CheckStatus.FAILED, message=message)
+        return CheckResult(
+            connector=connector, check=self, status=CheckStatus.FAILED, message=message
+        )
 
     def skip(self, connector: Connector, reason: str) -> CheckResult:
         """Create a skipped check result.
@@ -263,7 +272,9 @@ def skip(self, connector: Connector, reason: str) -> CheckResult:
         Returns:
             CheckResult: A skipped check result
         """
-        return CheckResult(connector=connector, check=self, status=CheckStatus.SKIPPED, message=reason)
+        return CheckResult(
+            connector=connector, check=self, status=CheckStatus.SKIPPED, message=reason
+        )
 
     def create_check_result(self, connector: Connector, passed: bool, message: str) -> CheckResult:
         """Create a check result based on whether the check passed or failed.
@@ -326,23 +337,31 @@ def to_json(self) -> str:
                 "message": check_result.message,
             }
             if check_result.status == CheckStatus.PASSED:
-                connectors_report[connector.technical_name]["passed_checks"].append(check_name_and_message)
+                connectors_report[connector.technical_name]["passed_checks"].append(
+                    check_name_and_message
+                )
                 connectors_report[connector.technical_name]["successful_checks_count"] += 1
                 connectors_report[connector.technical_name]["total_checks_count"] += 1
 
             elif check_result.status == CheckStatus.FAILED:
-                connectors_report[connector.technical_name]["failed_checks"].append(check_name_and_message)
+                connectors_report[connector.technical_name]["failed_checks"].append(
+                    check_name_and_message
+                )
                 connectors_report[connector.technical_name]["failed_checks_count"] += 1
                 connectors_report[connector.technical_name]["total_checks_count"] += 1
 
             elif check_result.status == CheckStatus.SKIPPED:
-                connectors_report[connector.technical_name]["skipped_checks"].append(check_name_and_message)
+                connectors_report[connector.technical_name]["skipped_checks"].append(
+                    check_name_and_message
+                )
                 connectors_report[connector.technical_name]["skipped_checks_count"] += 1
             else:
                 raise ValueError(f"Invalid check status {check_result.status}")
         for connector_technical_name in connectors_report.keys():
             connectors_report[connector_technical_name]["badge_color"] = (
-                "red" if connectors_report[connector_technical_name]["failed_checks_count"] > 0 else "green"
+                "red"
+                if connectors_report[connector_technical_name]["failed_checks_count"] > 0
+                else "green"
             )
             badge_name = self.badge_name.replace(" ", "_")
             badge_text = f"{connectors_report[connector_technical_name]['successful_checks_count']}/{connectors_report[connector_technical_name]['total_checks_count']}".replace(