pr feedback and cleaning up a few things, fix a test that was failing

Author: brianjlai

airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py

@@ -2892,6 +2892,9 @@ def create_simple_retriever(
         ):
             query_properties_definitions = []
             for key, request_parameter in model.requester.request_parameters.items():
+                # When translating JSON schema into Pydantic models, enforcing types for arrays containing both
+                # concrete string complex object definitions like QueryProperties would get resolved to Union[str, Any].
+                # This adds the extra validation that we couldn't get for free in Pydantic model generation
                 if (
                     isinstance(request_parameter, Mapping)
                     and request_parameter.get("type") == "QueryProperties"

airbyte_cdk/sources/declarative/requesters/query_properties/properties_from_endpoint.py

@@ -13,7 +13,8 @@
 @dataclass
 class PropertiesFromEndpoint:
     """
-    tbd
+    Component that defines the behavior around how to dynamically retrieve a set of request properties from an
+    API endpoint. The set retrieved can then be injected into the requests to extract records from an API source.
     """
 
     property_field_path: List[str]
@@ -36,5 +37,4 @@ def get_properties_from_endpoint(self, stream_slice: Optional[StreamSlice]) -> I
                 node.eval(self.config) if not isinstance(node, str) else node
                 for node in self._property_field_path
             ]
-
-            yield dpath.get(property_obj, path)  # type: ignore # extracted will be a MutableMapping, given input data structure
+            yield dpath.get(property_obj, path, default=[])  # type: ignore # extracted will be a MutableMapping, given input data structure

airbyte_cdk/sources/declarative/requesters/query_properties/property_chunking.py

@@ -13,7 +13,8 @@
 
 class PropertyLimitType(Enum):
     """
-    yeah
+    The heuristic that determines when the maximum size of the current chunk of properties and when a new
+    one should be started.
     """
 
     characters = "characters"

airbyte_cdk/sources/declarative/requesters/query_properties/query_properties.py

@@ -39,7 +39,7 @@ def get_request_property_chunks(
                 property_fields=fields, always_include_properties=self.always_include_properties
             )
         else:
-            yield from [list(fields)]
+            yield list(fields)
 
     def has_multiple_chunks(self, stream_slice: Optional[StreamSlice]) -> bool:
         property_chunks = iter(self.get_request_property_chunks(stream_slice=stream_slice))

unit_tests/sources/declarative/test_manifest_declarative_source.py

@@ -627,7 +627,6 @@ def test_source_missing_checker_fails_validation(self):
                     },
                 }
             ],
-            "check": {"type": "CheckStream"},
         }
         with pytest.raises(ValidationError):
             ManifestDeclarativeSource(source_config=manifest)