Skip to content

Commit 63ade32

Browse files
committed
document client secret empty
1 parent 036e709 commit 63ade32

File tree

1 file changed

+2
-2
lines changed
  • airbyte_cdk/sources/declarative/auth

1 file changed

+2
-2
lines changed

airbyte_cdk/sources/declarative/auth/oauth.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class DeclarativeOauth2Authenticator(AbstractOauth2Authenticator, DeclarativeAut
3333
Attributes:
3434
token_refresh_endpoint (Union[InterpolatedString, str]): The endpoint to refresh the access token
3535
client_id (Union[InterpolatedString, str]): The client id
36-
client_secret (Union[InterpolatedString, str]): Client secret
36+
client_secret (Union[InterpolatedString, str]): Client secret (can be empty for APIs that support this)
3737
refresh_token (Union[InterpolatedString, str]): The token used to refresh the access token
3838
access_token_name (Union[InterpolatedString, str]): THe field to extract access token from in the response
3939
expires_in_name (Union[InterpolatedString, str]): The field to extract expires_in from in the response
@@ -208,7 +208,7 @@ def get_client_secret(self) -> str:
208208
logger.warning(
209209
"OAuthAuthenticator was unable to evaluate client_secret parameter hence it'll be empty"
210210
)
211-
return client_secret # type: ignore # value will be returned as a string, or an error will be raised
211+
return client_secret # type: ignore # value will be returned as a string, which might be empty
212212

213213
def get_refresh_token_name(self) -> str:
214214
return self._refresh_token_name.eval(self.config) # type: ignore # eval returns a string in this context

0 commit comments

Comments
 (0)