Skip to content

Commit 666bd76

Browse files
committed
add test for transformations not passing downstream
1 parent bbc4bf1 commit 666bd76

File tree

1 file changed

+27
-1
lines changed

1 file changed

+27
-1
lines changed

unit_tests/sources/declarative/parsers/test_model_to_component_factory.py

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3828,13 +3828,29 @@ def test_create_async_retriever():
38283828
},
38293829
}
38303830

3831+
transformations = [
3832+
AddFields(
3833+
fields=[
3834+
AddedFieldDefinition(
3835+
path=["field1"],
3836+
value=InterpolatedString(
3837+
string="static_value", default="static_value", parameters={}
3838+
),
3839+
value_type=None,
3840+
parameters={},
3841+
)
3842+
],
3843+
parameters={},
3844+
)
3845+
]
3846+
38313847
component = factory.create_component(
38323848
model_type=AsyncRetrieverModel,
38333849
component_definition=definition,
38343850
name="test_stream",
38353851
primary_key="id",
38363852
stream_slicer=None,
3837-
transformations=[],
3853+
transformations=transformations,
38383854
config=config,
38393855
)
38403856

@@ -3864,6 +3880,16 @@ def test_create_async_retriever():
38643880
assert isinstance(extractor, DpathExtractor)
38653881
assert extractor.field_path == ["data"]
38663882

3883+
# Validate the transformations are just passed to the async retriever record_selector but not the download retriever record_selector
3884+
assert selector.transformations == transformations
3885+
download_retriever_record_selector: RecordSelector = (
3886+
job_repository.download_retriever.record_selector
3887+
) # type: ignore
3888+
assert download_retriever_record_selector.transformations != transformations
3889+
assert not download_retriever_record_selector.transformations
3890+
assert download_retriever_record_selector.record_filter is None
3891+
assert download_retriever_record_selector.schema_normalization._config.name == "NoTransform"
3892+
38673893

38683894
def test_api_budget():
38693895
manifest = {

0 commit comments

Comments
 (0)