Move default log_formatter value to post init

Author: lazebnyi

airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py

@@ -3171,12 +3171,7 @@ def _get_url() -> str:
                 config=config,
                 maximum_number_of_slices=self._limit_slices_fetched or 5,
                 ignore_stream_slicer_parameters_on_paginated_requests=ignore_stream_slicer_parameters_on_paginated_requests,
-                log_formatter=(lambda response: format_http_message(
-                    response,
-                    f"Stream '{name}' request",
-                    f"Request performed in order to extract records for stream '{name}'",
-                    name,
-                )) if not log_formatter else log_formatter,
+                log_formatter=log_formatter,
                 parameters=model.parameters or {},
             )
         return SimpleRetriever(

airbyte_cdk/sources/declarative/retrievers/simple_retriever.py

@@ -22,7 +22,7 @@
 
 import requests
 from typing_extensions import deprecated
-
+from airbyte_cdk.sources.http_logger import format_http_message
 from airbyte_cdk.models import AirbyteMessage
 from airbyte_cdk.sources.declarative.extractors.http_selector import HttpSelector
 from airbyte_cdk.sources.declarative.incremental import ResumableFullRefreshCursor
@@ -655,6 +655,13 @@ class SimpleRetrieverTestReadDecorator(SimpleRetriever):
 
     def __post_init__(self, options: Mapping[str, Any]) -> None:
         super().__post_init__(options)
+        self.log_formatter = (lambda response: format_http_message(
+                    response,
+                    f"Stream '{self.name}' request",
+                    f"Request performed in order to extract records for stream '{self.name}'",
+                    self.name,
+                )) if not self.log_formatter else self.log_formatter
+
         if self.maximum_number_of_slices and self.maximum_number_of_slices < 1:
             raise ValueError(
                 f"The maximum number of slices on a test read needs to be strictly positive. Got {self.maximum_number_of_slices}"

unit_tests/sources/declarative/retrievers/test_simple_retriever.py

@@ -921,11 +921,8 @@ def test_emit_log_request_response_messages(mocker):
         stream_state={}, stream_slice=StreamSlice(cursor_slice={}, partition={})
     )
 
-    assert requester.send_request.call_args_list[0][1]["log_formatter"] is not None
-    assert (
-        requester.send_request.call_args_list[0][1]["log_formatter"](response)
-        == format_http_message_mock.return_value
-    )
+    assert retriever.log_formatter is not None
+    assert retriever.log_formatter(response) == format_http_message_mock.return_value
 
 
 def test_retriever_last_page_size_for_page_increment():