Skip to content

Commit 6cf6e1c

Browse files
fix: Add missing config parameter in _uses_dynamic_schema_loader method
- Fixed TypeError in ManifestDeclarativeSource._stream_configs() missing required positional argument 'config' - Added empty_config parameter when calling _stream_configs during schema detection - This enables config-free discover to work for static schema connectors Manual testing shows this fixes the immediate TypeError but additional work needed for datetime parsing issues. Co-Authored-By: AJ Steers <[email protected]>
1 parent b956a30 commit 6cf6e1c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

airbyte_cdk/sources/declarative/manifest_declarative_source.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,8 @@ def _uses_dynamic_schema_loader(self) -> bool:
617617
Returns:
618618
bool: True if any stream uses a DynamicSchemaLoader, False otherwise.
619619
"""
620-
for stream_config in self._stream_configs(self._source_config):
620+
empty_config: Dict[str, Any] = {}
621+
for stream_config in self._stream_configs(self._source_config, empty_config):
621622
schema_loader = stream_config.get("schema_loader", {})
622623
if (
623624
isinstance(schema_loader, dict)

airbyte_cdk/test/standard_tests/source_base.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
import pytest
88

9-
from airbyte_cdk.models import (
109
from airbyte_cdk.models import (
1110
AirbyteMessage,
1211
AirbyteStream,

0 commit comments

Comments
 (0)