Skip to content

Commit 701efe3

Browse files
committed
fixes
1 parent 2e587c4 commit 701efe3

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

airbyte_cdk/test/standard_tests/docker_base.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -113,15 +113,15 @@ def test_docker_image_build_and_spec(
113113
connector_image_override: str | None,
114114
) -> None:
115115
"""Run `docker_image` acceptance tests."""
116-
connector_dir = self.get_connector_root_dir()
117-
metadata = MetadataFile.from_file(connector_dir / "metadata.yaml")
116+
connector_root = self.get_connector_root_dir()
117+
metadata = MetadataFile.from_file(connector_root / "metadata.yaml")
118118

119119
connector_image: str | None = connector_image_override
120120
if not connector_image:
121121
tag = "dev-latest"
122122
connector_image = build_connector_image(
123-
connector_name=connector_dir.name,
124-
connector_directory=connector_dir,
123+
connector_name=connector_root.name,
124+
connector_directory=connector_root,
125125
metadata=metadata,
126126
tag=tag,
127127
no_verify=False,
@@ -162,21 +162,23 @@ def test_docker_image_build_and_check(
162162
pytest.skip("Skipping test_docker_image_build_and_check (expected to fail).")
163163

164164
tag = "dev-latest"
165-
connector_dir = self.get_connector_root_dir()
166-
metadata = MetadataFile.from_file(connector_dir / "metadata.yaml")
165+
connector_root = self.get_connector_root_dir()
166+
metadata = MetadataFile.from_file(connector_root / "metadata.yaml")
167167
connector_image: str | None = connector_image_override
168168
if not connector_image:
169169
tag = "dev-latest"
170170
connector_image = build_connector_image(
171-
connector_name=connector_dir.name,
172-
connector_directory=connector_dir,
171+
connector_name=connector_root.name,
172+
connector_directory=connector_root,
173173
metadata=metadata,
174174
tag=tag,
175175
no_verify=False,
176176
)
177177

178178
container_config_path = "/secrets/config.json"
179-
with scenario.with_temp_config_file() as temp_config_file:
179+
with scenario.with_temp_config_file(
180+
connector_root=connector_root,
181+
) as temp_config_file:
180182
_ = run_docker_command(
181183
[
182184
"docker",

0 commit comments

Comments
 (0)