Skip to content

Commit 8071e89

Browse files
author
Oleksandr Bazarnov
committed
updated after the review
1 parent f5b256e commit 8071e89

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

airbyte_cdk/sources/declarative/declarative_component_schema.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3684,7 +3684,7 @@ interpolation:
36843684
description: The `URL` received from the polling_requester in the AsyncRetriever with jobStatus as `COMPLETED`.
36853685
type: string
36863686
examples:
3687-
- url: "https://api.sendgrid.com/v3/marketing/lists?page_size=1&page_token=0236d6d2&filename=xxx_yyy_zzz.csv"
3687+
- "https://api.sendgrid.com/v3/marketing/lists?page_size=1&page_token=0236d6d2&filename=xxx_yyy_zzz.csv"
36883688
- title: stream_interval
36893689
description: The current stream interval being processed. The keys are defined by the incremental sync component. Default keys are `start_time` and `end_time`.
36903690
type: object

airbyte_cdk/sources/declarative/requesters/http_job_repository.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -211,14 +211,14 @@ def fetch_records(self, job: AsyncJob) -> Iterable[Mapping[str, Any]]:
211211
212212
"""
213213

214-
for url in self._get_download_url(job):
214+
for target_url in self._get_download_targets(job):
215215
job_slice = job.job_parameters()
216216
stream_slice = StreamSlice(
217217
partition=job_slice.partition,
218218
cursor_slice=job_slice.cursor_slice,
219219
extra_fields={
220220
**job_slice.extra_fields,
221-
"download_target": url,
221+
"download_target": target_url,
222222
},
223223
)
224224
for message in self.download_retriever.read_records({}, stream_slice):
@@ -280,7 +280,7 @@ def _get_create_job_stream_slice(self, job: AsyncJob) -> StreamSlice:
280280
)
281281
return stream_slice
282282

283-
def _get_download_url(self, job: AsyncJob) -> Iterable[str]:
283+
def _get_download_targets(self, job: AsyncJob) -> Iterable[str]:
284284
if not self.url_requester:
285285
url_response = self._polling_job_response_by_id[job.api_job_id()]
286286
else:

0 commit comments

Comments
 (0)