Skip to content

Commit 86909df

Browse files
authored
Merge branch 'maxi297/bland_stream_instantiated_as_defaultstream' into maxi297/incremental_without_partition_router_as_defaultstream
2 parents 6cb012b + 11e3a35 commit 86909df

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

airbyte_cdk/sources/declarative/concurrent_declarative_source.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ def _group_streams(
466466
partition_generator = StreamSlicerPartitionGenerator(
467467
DeclarativePartitionFactory(
468468
stream_name=declarative_stream.name,
469-
schema_loader=declarative_stream._schema_loader, # type: ignore # We are accessing the private property but the public one is optional and we will remove this code soonish
469+
schema_loader=declarative_stream._schema_loader, # type: ignore # We are accessing the private property but the public one is optional and we will remove this code soonish
470470
retriever=retriever,
471471
message_repository=self.message_repository,
472472
max_records_limit=self._limits.max_records if self._limits else None,

airbyte_cdk/sources/declarative/stream_slicers/declarative_partition_generator.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,9 @@ def read(self) -> Iterable[Record]:
8686
global total_record_counter
8787
if total_record_counter >= self._max_records_limit:
8888
return
89-
for stream_data in self._retriever.read_records(self._schema_loader.get_json_schema(), self._stream_slice):
89+
for stream_data in self._retriever.read_records(
90+
self._schema_loader.get_json_schema(), self._stream_slice
91+
):
9092
if self._max_records_limit:
9193
if total_record_counter >= self._max_records_limit:
9294
break

unit_tests/connector_builder/test_connector_builder_handler.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,11 @@ def test_config_update() -> None:
785785
"refresh_token": "a refresh token",
786786
}
787787
source = ConcurrentDeclarativeSource(
788-
catalog=None, config=config, state=None, source_config=manifest, emit_connector_builder_messages=True,
788+
catalog=None,
789+
config=config,
790+
state=None,
791+
source_config=manifest,
792+
emit_connector_builder_messages=True,
789793
)
790794

791795
refresh_request_response = {

0 commit comments

Comments
 (0)