Skip to content

Commit 8c771bb

Browse files
author
maxime.c
committed
partially fix mypy
1 parent 1af2264 commit 8c771bb

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2066,8 +2066,8 @@ def create_declarative_stream(
20662066
# We specifically exclude Connector Builder stuff for now as Brian is working on this anyway
20672067

20682068
stream_name = model.name or ""
2069-
stream_slicer = concurrent_cursor
2070-
cursor = FinalStateCursor(stream_name, None, self._message_repository)
2069+
stream_slicer: StreamSlicer = concurrent_cursor
2070+
cursor: Cursor = FinalStateCursor(stream_name, None, self._message_repository)
20712071
if isinstance(retriever, AsyncRetriever):
20722072
# The AsyncRetriever only ever worked with a cursor from the concurrent package. Hence, the method
20732073
# `_build_incremental_cursor` which we would usually think would return only declarative stuff has a
@@ -2126,19 +2126,18 @@ def create_declarative_stream(
21262126
)
21272127

21282128
def _is_stop_condition_on_cursor(self, model: DeclarativeStreamModel) -> bool:
2129-
return (
2129+
return bool(
21302130
model.incremental_sync
21312131
and hasattr(model.incremental_sync, "is_data_feed")
21322132
and model.incremental_sync.is_data_feed
21332133
)
21342134

21352135
def _is_client_side_filtering_enabled(self, model: DeclarativeStreamModel) -> bool:
2136-
client_side_filtering_enabled = (
2136+
return bool(
21372137
model.incremental_sync
21382138
and hasattr(model.incremental_sync, "is_client_side_incremental")
21392139
and model.incremental_sync.is_client_side_incremental
21402140
)
2141-
return client_side_filtering_enabled
21422141

21432142
def _build_stream_slicer_from_partition_router(
21442143
self,

0 commit comments

Comments
 (0)