Skip to content

Commit 8fae49e

Browse files
author
maxi297
committed
document test better
1 parent 06ff322 commit 8fae49e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

unit_tests/sources/declarative/decoders/test_composite_decoder.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,10 @@ def do_GET(self) -> None:
212212
self.wfile.write(bytes("col1,col2\nval1,val2", 'utf-8'))
213213

214214

215-
def test_composite_raw_decoder_csv_parser():
215+
def test_composite_raw_decoder_csv_parser_without_mocked_response():
216+
"""
217+
This test reproduce a `ValueError: I/O operation on closed file` error we had with CSV parsing. We could not catch this with other tests because the closing of the mocked response from requests_mock was not the same as the one in requests.
218+
"""
216219
# start server
217220
httpd = HTTPServer(('localhost', 8080), TestServer)
218221
thread = Thread(target=httpd.serve_forever, args = ())

0 commit comments

Comments
 (0)