Skip to content

Commit 93b251c

Browse files
committed
refactor file write
1 parent fcfb82a commit 93b251c

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

airbyte_cdk/cli/airbyte_cdk/_secrets.py

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,11 @@ def fetch(
111111
secrets_dir=secrets_dir,
112112
secret=secret,
113113
)
114-
secret_file_path.write_text(_get_secret_value(secret=secret, client=client))
115-
secret_file_path.chmod(0o600) # default to owner read/write only
114+
_write_secret_file(
115+
secret=secret,
116+
client=client,
117+
file_path=secret_file_path,
118+
)
116119
click.echo(f"Secret written to: {secret_file_path.absolute()!s}")
117120
secret_count += 1
118121

@@ -185,9 +188,9 @@ def list_(
185188
table.add_column("Last Updated", justify="left", style="blue", overflow="fold")
186189
for secret in secrets:
187190
table.add_row(
188-
secret.name.split("/secrets/")[-1],
189-
str(secret.create_time),
191+
secret.name.split("/secrets/")[-1], # Name of the secret, without the prefix
190192
"\n".join([f"{k}={v}" for k, v in secret.labels.items()]),
193+
str(secret.create_time),
191194
)
192195

193196
console.print(table)
@@ -219,13 +222,15 @@ def _fetch_secret_handles(
219222
return [s for s in secrets]
220223

221224

222-
def _get_secret_value(
223-
secret: "Secret", # type: ignore
224-
client: "secretmanager.SecretManagerServiceClient", # type: ignore
225-
) -> str:
225+
def _write_secret_file(
226+
secret: "Secret", # type: ignore
227+
client: "secretmanager.SecretManagerServiceClient", # type: ignore
228+
file_path: Path,
229+
) -> None:
226230
version_name = f"{secret.name}/versions/latest"
227231
response = client.access_secret_version(name=version_name)
228-
return response.payload.data.decode("UTF-8")
232+
file_path.write_text(response.payload.data.decode("UTF-8"))
233+
file_path.chmod(0o600) # default to owner read/write only
229234

230235

231236
def _get_secrets_dir(

0 commit comments

Comments
 (0)