Skip to content

Commit 962ddbe

Browse files
committed
file-mode-api: make uploader updates record file_reference field
1 parent 7a02ec8 commit 962ddbe

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

airbyte_cdk/sources/declarative/retrievers/file_uploader.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def __init__(
2323
self._download_target_extractor = download_target_extractor
2424
self._content_extractor = content_extractor
2525

26-
def upload(self, record: Record) -> AirbyteRecordMessageFileReference:
26+
def upload(self, record: Record) -> None:
2727
# TODO validate record shape - is the transformation applied at this point?
2828
mocked_response = SafeResponse()
2929
mocked_response.content = json.dumps(record.data).encode("utf-8")
@@ -54,8 +54,8 @@ def upload(self, record: Record) -> AirbyteRecordMessageFileReference:
5454
f.write(response.content)
5555
file_size_bytes = full_path.stat().st_size
5656

57-
return AirbyteRecordMessageFileReference(
58-
file_url=download_target,
59-
file_relative_path=str(file_relative_path),
60-
file_size_bytes=file_size_bytes,
61-
)
57+
record.file_reference = AirbyteRecordMessageFileReference(
58+
file_url=download_target,
59+
file_relative_path=str(file_relative_path),
60+
file_size_bytes=file_size_bytes,
61+
)

airbyte_cdk/sources/declarative/stream_slicers/declarative_partition_generator.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,7 @@ def read(self) -> Iterable[Record]:
7474
)
7575
)
7676
if self._file_uploader:
77-
file_reference = self._file_uploader.upload(record)
78-
record.file_reference = file_reference
77+
self._file_uploader.upload(record)
7978
yield record
8079
else:
8180
self._message_repository.emit_message(stream_data)

0 commit comments

Comments
 (0)