Skip to content

Commit 972cc60

Browse files
committed
minor improvements to the development flow int the cdk. automatically format python files after generating pydnatic models, upgrade dagger version, install dagger normally as a dev poetry dependency, allow specifying a custom manifest file path in IDE debug configuration.
1 parent ae0e8aa commit 972cc60

File tree

5 files changed

+204
-29
lines changed

5 files changed

+204
-29
lines changed

bin/generate-component-manifest-dagger.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,4 @@
77

88
set -e
99

10-
pip install dagger-io==0.13.3
1110
python bin/generate_component_manifest_files.py

debug_manifest/README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,15 @@ To configure the debugger in VSCode to run the `debug_manifest`, follow these st
2222
"request": "launch",
2323
"console": "integratedTerminal",
2424
"cwd": "${workspaceFolder}/debug_manifest",
25-
"python": "<PATH_TO_CDK_ENV>/bin/python",
25+
"python": "<PATH_TO_CDK_ENV>/bin/python", // REPLACE ME
2626
"module": "debug_manifest",
2727
"args": [
2828
// SPECIFY THE COMMAND: [spec, check, discover, read]
2929
"read",
30+
// SPECIFY THE MANIFEST FILE
31+
"--manifest-path",
32+
// PATH TO THE MANIFEST FILE
33+
"resources/manifest.yaml",
3034
// SPECIFY THE CONFIG
3135
"--config",
3236
// PATH TO THE CONFIG FILE

debug_manifest/debug_manifest.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,15 @@ def debug_manifest(source: YamlDeclarativeSource, args: list[str]) -> None:
2424

2525
if __name__ == "__main__":
2626
args = sys.argv[1:]
27+
parsed_args = AirbyteEntrypoint.parse_args(args)
28+
manifest_path = AirbyteEntrypoint.parse_args(args).manifest_path or "resources/manifest.yaml"
2729
catalog_path = AirbyteEntrypoint.extract_catalog(args)
2830
config_path = AirbyteEntrypoint.extract_config(args)
2931
state_path = AirbyteEntrypoint.extract_state(args)
3032

3133
debug_manifest(
3234
YamlDeclarativeSource(
33-
path_to_yaml="resources/manifest.yaml",
35+
path_to_yaml=manifest_path,
3436
catalog=YamlDeclarativeSource.read_catalog(catalog_path) if catalog_path else None,
3537
config=YamlDeclarativeSource.read_config(config_path) if config_path else None,
3638
state=YamlDeclarativeSource.read_state(state_path) if state_path else None,

0 commit comments

Comments
 (0)